[HOLD for payment 2024-07-10] [$250] Workspace - Error page when navigate to Workspace Join link after leaving the workspace

@isabelastisser

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.81-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4609575&group_by=cases:section_id&group_order=asc&group_id=229065
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Login to staging.expensify.com
Navigate to this link - https://staging.new.expensify.com/settings/workspaces/CEFA9CA2E2CBFFC0/join?email=applausetester+joinlink@applause.expensifail.com
Click on 3-dot menu> Leave
Navigate to this link again - https://staging.new.expensify.com/settings/workspaces/CEFA9CA2E2CBFFC0/join?email=applausetester+joinlink@applause.expensifail.com

Expected Result:

User should be able to navigate to the workspace

Actual Result:

Error page when navigate to Workspace Join link after leaving the workspace

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6508578_1718048869729.Recording__3163.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0191daed4e48342857
Upwork Job ID: 1800535491968568315
Last Price Increase: 2024-06-25
Automatic offers:

allgandalf | Reviewer | 102892807
bernhardoj | Contributor | 102892809

Issue Owner

Current Issue Owner: @isabelastisser

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@isabelastisser

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

The not found page is shown when we reopen the workspace join link after leaving it.

What is the root cause of that problem?

When we successfully leave from a workspace, we still keep the policy object data. It's really weird that the pending action is still delete.

App/src/libs/actions/Policy/Policy.ts

Lines 649 to 660 in 65db650

    
           const successData: OnyxUpdate[] = [ 
        
               { 
        
                   onyxMethod: Onyx.METHOD.MERGE, 
        
                   key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`, 
        
                   value: { 
        
                       pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE, 
        
                       employeeList: { 
        
                           [sessionEmail]: null, 
        
                       }, 
        
                   }, 
        
               }, 
        
           ];

When we reopen the join link/page, the condition below detects that the workspace exists, thus we are navigated to the profile page.

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Lines 45 to 51 in 65db650

    
           if (!isEmptyObject(policy) && !policy?.isJoinRequestPending) { 
        
               Navigation.isNavigationReady().then(() => { 
        
                   Navigation.goBack(undefined, false, true); 
        
                   Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID ?? '')); 
        
               }); 
        
               return; 
        
           }

The not found page will be shown if the policy/workspace has a pending action of delete, thus we see the not found page.

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 153 in 65db650

    
           (PolicyUtils.isPendingDeletePolicy(policy) && PolicyUtils.isPendingDeletePolicy(prevPolicy))

What changes do you think we should make in order to solve the problem?

First, we should clear the policy data after successfully leaving a workspace.

const successData: OnyxUpdate[] = [
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
        value: null,
    },
];

Next, because not found page will be shown for pending delete workspace, we need to add a new check here to make sure the pending action is not delete so we don't get navigated to the not found workspace profile page.

App/src/pages/workspace/WorkspaceJoinUserPage.tsx

Lines 45 to 51 in 65db650

    
           if (!isEmptyObject(policy) && !policy?.isJoinRequestPending) { 
        
               Navigation.isNavigationReady().then(() => { 
        
                   Navigation.goBack(undefined, false, true); 
        
                   Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID ?? '')); 
        
               }); 
        
               return; 
        
           }

if (!isEmptyObject(policy) && !policy?.isJoinRequestPending && !PolicyUtils.isPendingDeletePolicy(policy)) {

We can optionally check for the policy ID. Let me know if we want to do that

Job added to Upwork: https://www.upwork.com/jobs/~0191daed4e48342857

@abdulrahuman5196

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@abdulrahuman5196

@abdulrahuman5196, can you please review the proposal above? Thanks!

@AndrewGable

@AndrewGable can you please review the regression test proposal? thanks!

@bernhardoj

$250 approved for @bernhardoj

@AndrewGable

@AndrewGable #43436 (comment)

Yes, looks good

All set!

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-10] [$250] Workspace - Error page when navigate to Workspace Join link after leaving the workspace #43436

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

51 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const successData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	employeeList: {
	[sessionEmail]: null,
	},
	},
	},
	];

	if (!isEmptyObject(policy) && !policy?.isJoinRequestPending) {
	Navigation.isNavigationReady().then(() => {
	Navigation.goBack(undefined, false, true);
	Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID ?? ''));
	});
	return;
	}

[HOLD for payment 2024-07-10] [$250] Workspace - Error page when navigate to Workspace Join link after leaving the workspace #43436

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 10, 2024

m-natarajan commented on Jun 10, 2024

bernhardoj commented on Jun 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Jun 11, 2024

melvin-bot commented on Jun 11, 2024

isabelastisser commented on Jun 14, 2024

51 remaining items

isabelastisser commented on Jul 10, 2024

JmillsExpensify commented on Jul 10, 2024

isabelastisser commented on Jul 12, 2024

AndrewGable commented on Jul 15, 2024

isabelastisser commented on Jul 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions