User is able to upload a file larger than 50mb

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue is failing #4269 for Android

Action Performed:

Open the app and log in
Navigate to a conversation
Click on add attachment
Select a file larger than 50mb

Expected Result:

There should be a message saying that the file must be under 50mb to upload

Actual Result:

There's a thumbnail for the attachment with a spinner and the file is not uploaded

Workaround:

Unknown

Platform:

Where is this issue occurring?

Android

Version Number: 1.0.82-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
We were unable to check if this issue is reproducible in iOS since the build is failing.

Screen_Recording_20210801-132457_Expensifycash.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@timszot

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Can reproduce the issue.
I'm on it.

@rushatgabhane

@rushatgabhane I've missed your comments was checking this issue. I've narrowed it down and handled,

Proposal

Need to change the following lines,

App/src/components/AttachmentPicker/index.native.js

Lines 98 to 107 in 87cbc24

    
           pickAttachment(attachment) { 
        
               if (attachment) { 
        
                   if (attachment.width === -1 || attachment.height === -1) { 
        
                       this.showImageCorruptionAlert(); 
        
                       return; 
        
                   } 
        
                   const result = getDataForUpload(attachment); 
        
                   this.completeAttachmentSelection(result); 
        
               } 
        
           }

As shown below,

We can change Growl to Alert if needed(this is mobile-only issue we can use native Alert also), thanks!

Demo:

Screen_Recording_20210802-004726_Expensifycash.mp4

Update: fix is ready.

Just needed to pass size: fileData.size over here.

App/src/components/AttachmentPicker/index.native.js

Lines 48 to 52 in 87cbc24

    
           function getDataForUpload(fileData) { 
        
               return { 
        
                   name: fileData.fileName || fileData.name || 'chat_attachment', 
        
                   type: fileData.type, 
        
                   uri: fileData.uri,

@Santhosh-Sellavel

@Santhosh-Sellavel Thanks for your input!
Pushed a simpler fix instead.

Retest for this was a pass! Closing the issue 🎉

Navigation Menu

Repository navigation

User is able to upload a file larger than 50mb #4356

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	pickAttachment(attachment) {
	if (attachment) {
	if (attachment.width === -1 \|\| attachment.height === -1) {
	this.showImageCorruptionAlert();
	return;
	}
	const result = getDataForUpload(attachment);
	this.completeAttachmentSelection(result);
	}
	}

	function getDataForUpload(fileData) {
	return {
	name: fileData.fileName \|\| fileData.name \|\| 'chat_attachment',
	type: fileData.type,
	uri: fileData.uri,

User is able to upload a file larger than 50mb #4356

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

MelvinBot commented on Aug 1, 2021

OSBotify commented on Aug 1, 2021

rushatgabhane commented on Aug 1, 2021

rushatgabhane commented on Aug 1, 2021

Santhosh-Sellavel commented on Aug 1, 2021

Proposal

rushatgabhane commented on Aug 1, 2021

rushatgabhane commented on Aug 1, 2021

isagoico commented on Aug 3, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions