[HOLD for payment 2024-07-17] [$250] Actionable whisper - Whisper options are interactable when the expense is deleted offline

@CortneyOfstad

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when validating #43020
Version Number: 1.4.82-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go offline.
Go to Self DM.
Track an expense.
Go to transaction thread.
Delete the expense.
Back in 1:1 DM, click on any option in actionable whisper.

Expected Result:

The actionable whisper should not be interactable when the expense is deleted offline.

Actual Result:

The actionable whisper is interactable when the expense is deleted offline and the options (except Nothing for now) lead to not here page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6510127_1718153439897.20240612_084634.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0102bf6b299104a911
Upwork Job ID: 1801628978700613798
Last Price Increase: 2024-06-14
Automatic offers:

rojiphil | Reviewer | 102784394
truph01 | Contributor | 102784396

Issue Owner

Current Issue Owner: @CortneyOfstad

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@CortneyOfstad

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

Proposal

Please re-state the problem that we are trying to solve in this issue.

Actionable whisper - Whisper options are interactable when the expense is deleted offline

What is the root cause of that problem?

We don't have any logic to disable the buttons when the transaction is deleted.

App/src/pages/home/report/ReportActionItem.tsx

Lines 401 to 417 in 79e619a

    
           const actionableItemButtons: ActionableItem[] = useMemo(() => { 
        
               if (!isActionableWhisper && (!ReportActionsUtils.isActionableJoinRequest(action) || action.originalMessage.choice !== ('' as JoinWorkspaceResolution))) { 
        
                   return []; 
        
               } 
        
               if (ReportActionsUtils.isActionableTrackExpense(action)) { 
        
                   const transactionID = action?.originalMessage?.transactionID; 
        
                   return [ 
        
                       { 
        
                           text: 'actionableMentionTrackExpense.submit', 
        
                           key: `${action.reportActionID}-actionableMentionTrackExpense-submit`, 
        
                           onPress: () => { 
        
                               ReportUtils.createDraftTransactionAndNavigateToParticipantSelector(transactionID, report.reportID, CONST.IOU.ACTION.SUBMIT, action.reportActionID); 
        
                           }, 
        
                           isMediumSized: true, 
        
                       }, 
        
                       {

What changes do you think we should make in order to solve the problem?

We should get the transaction using transactionID and if the transaction doesn't exist, we will disable the buttons. In order to make this work we need to follow few steps.

Get all transactions using useOnyx in ReportActionItem.

const [transactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION);

Get the transaction details using the transactionID.

const transactionID = action?.originalMessage?.transactionID;
const transaction = transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`] ?? null;

App/src/pages/home/report/ReportActionItem.tsx

Lines 401 to 410 in 79e619a

    
           const actionableItemButtons: ActionableItem[] = useMemo(() => { 
        
               if (!isActionableWhisper && (!ReportActionsUtils.isActionableJoinRequest(action) || action.originalMessage.choice !== ('' as JoinWorkspaceResolution))) { 
        
                   return []; 
        
               } 
        
               if (ReportActionsUtils.isActionableTrackExpense(action)) { 
        
                   const transactionID = action?.originalMessage?.transactionID; 
        
                   return [ 
        
                       { 
        
                           text: 'actionableMentionTrackExpense.submit',

3. Add isDisabled property in the objects in actionableItemButtons array.

{
    text: 'actionableMentionTrackExpense.submit',
    key: `${action.reportActionID}-actionableMentionTrackExpense-submit`,
    onPress: () => {
        ReportUtils.createDraftTransactionAndNavigateToParticipantSelector(transactionID, report.reportID, CONST.IOU.ACTION.SUBMIT, action.reportActionID);
    },
    isMediumSized: true,
    isDisabled: !transactions,
},

Update ActionableItemButtton to pass the isDisabled prop.

App/src/components/ReportActionItem/ActionableItemButtons.tsx

Lines 28 to 36 in 79e619a

    
               <Button 
        
                   key={item.key} 
        
                   onPress={item.onPress} 
        
                   text={translate(item.text)} 
        
                   small={!item.isMediumSized} 
        
                   medium={item.isMediumSized} 
        
                   success={item.isPrimary} 
        
               /> 
        
           ))}

<Button
    key={item.key}
    onPress={item.onPress}
    text={translate(item.text)}
    small={!item.isMediumSized}
    medium={item.isMediumSized}
    success={item.isPrimary}
    isDisabled={item.isDisabled}
/>

Optional: We can wrap the Whisper message with OfflineWithFeedback.

App/src/pages/home/report/ReportActionItem.tsx

Line 767 in 79e619a

<ReportActionItemSingle

<OfflineWithFeedback pendingAction={ReportActionsUtils.isActionableTrackExpense(action) && !transaction && 'delete'}>

Note: We also need to update the type files.

What alternative solutions did you explore? (Optional)

We can also get the action transaction using the withOnyx HOC.
Instead of making the buttons disabled we can hide the buttons by returning empty array if transaction is falsy value.

Result

Monosnap.screencast.2024-06-12.21-08-45.mp4

Job added to Upwork: https://www.upwork.com/jobs/~0102bf6b299104a911

@rojiphil

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

@rojiphil

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Hide whisper action when deleting track expense in offline #43977

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

@rojiphil requires payment automatic offer (Reviewer)
@truph01 requires payment automatic offer (Contributor)

@rojiphil

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
[@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rojiphil] Determine if we should create a regression test for this bug.
[@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@rojiphil

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Hide whisper action when deleting track expense in offline #43977

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

@rojiphil requires payment automatic offer (Reviewer)
@truph01 requires payment automatic offer (Contributor)

@rojiphil

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
[@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rojiphil] Determine if we should create a regression test for this bug.
[@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@rojiphil

So the title is incorrect and this needs to be paid.

@rojiphil can you please complete the checklist by EOD? Thank you and sorry for the short notice!

@rojiphil

[@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
[@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
[@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.
[@rojiphil] Determine if we should create a regression test for this bug. : Since this feature was not implemented before, we can add the test case to the existing list of test cases for this track expense feature.
[@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Test Steps
1 Go offline.
2 Navigate to Self DM.
3 Track an expense.
4 Go to transaction thread.
5 Delete the expense.
6 Verify that the actionable whisper is not displayed.

@CortneyOfstad

can you please complete the checklist by EOD?

@CortneyOfstad Checklist is done.

@rojiphil

Payment Summary

@rojiphil — paid $250 via Upwork
@truph01 — paid $250 via Upwork

Regression Test

https://github.com/Expensify/Expensify/issues/414055

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-17] [$250] Actionable whisper - Whisper options are interactable when the expense is deleted offline #43560

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

36 remaining items

Payment Summary

Regression Test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const actionableItemButtons: ActionableItem[] = useMemo(() => {
	if (!isActionableWhisper && (!ReportActionsUtils.isActionableJoinRequest(action) \|\| action.originalMessage.choice !== ('' as JoinWorkspaceResolution))) {
	return [];
	}

	if (ReportActionsUtils.isActionableTrackExpense(action)) {
	const transactionID = action?.originalMessage?.transactionID;
	return [
	{
	text: 'actionableMentionTrackExpense.submit',
	key: `${action.reportActionID}-actionableMentionTrackExpense-submit`,
	onPress: () => {
	ReportUtils.createDraftTransactionAndNavigateToParticipantSelector(transactionID, report.reportID, CONST.IOU.ACTION.SUBMIT, action.reportActionID);
	},
	isMediumSized: true,
	},
	{

	<Button
	key={item.key}
	onPress={item.onPress}
	text={translate(item.text)}
	small={!item.isMediumSized}
	medium={item.isMediumSized}
	success={item.isPrimary}
	/>
	))}

[HOLD for payment 2024-07-17] [$250] Actionable whisper - Whisper options are interactable when the expense is deleted offline #43560

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 12, 2024

m-natarajan commented on Jun 12, 2024

m-natarajan commented on Jun 12, 2024

Krishna2323 commented on Jun 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

melvin-bot commented on Jun 14, 2024

melvin-bot commented on Jun 14, 2024

36 remaining items

melvin-bot commented on Jul 10, 2024

melvin-bot commented on Jul 10, 2024

melvin-bot commented on Jul 15, 2024

melvin-bot commented on Jul 15, 2024

CortneyOfstad commented on Jul 18, 2024

rojiphil commented on Jul 19, 2024

rojiphil commented on Jul 19, 2024

CortneyOfstad commented on Jul 19, 2024

Payment Summary

Regression Test

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions