Skip to content

[HOLD for payment 2024-07-24] [$250] QBO - "Required" remains enabled when all tags are disabled #43666

New issue
New issue
Closed
Closed
[HOLD for payment 2024-07-24] [$250] QBO - "Required" remains enabled when all tags are disabled#43666
Assignees
cead22akinwaledylanexpensifyKrishna2323
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Jun 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #42972

Action Performed:

Precondition:

  • Account is connected to QBO
  1. Go to staging.new.expensify.com
  2. Go to workspace settings
  3. Go to Tags
  4. Click Classes
  5. Toggle on Required
  6. Select all tags
  7. Disable all tags

Expected Result:

"Required" will be disabled and locked when all tags are disabled (same behavior when all categories are disabled)

Actual Result:

"Required" remains enabled when all tags are disabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512016_1718287352585.20240613_215711.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f4ad944ec831b5b7
  • Upwork Job ID: 1801300917150271805
  • Last Price Increase: 2024-06-13
  • Automatic offers:
    • akinwale | Reviewer | 102740102
    • Krishna2323 | Contributor | 102740104
Issue OwnerCurrent Issue Owner: @akinwale

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  2. melvin-bot
    assigned
    cead22
    on Jun 13, 2024

  3. melvin-bot commented on Jun 13, 2024

    @melvin-bot
    melvin-botBot
    on Jun 13, 2024 – with Melvin Bot

    Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    on Jun 13, 2024

  5. github-actions commented on Jun 13, 2024

    @github-actions
    github-actionsBot
    on Jun 13, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  6. lanitochka17 commented on Jun 13, 2024

    @lanitochka17
    lanitochka17
    on Jun 13, 2024
    Author

    @cead22 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  7. cead22
    added
    DailyKSv2
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Jun 13, 2024
  8. melvin-bot
    changed the title [-]QBO - "Required" remains enabled when all tags are disabled[/-] [+][$250] QBO - "Required" remains enabled when all tags are disabled[/+] on Jun 13, 2024

  9. melvin-bot commented on Jun 13, 2024

    @melvin-bot
    melvin-botBot
    on Jun 13, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01f4ad944ec831b5b7

  10. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 13, 2024

  11. 21 remaining items

  12. melvin-bot
    changed the title [-][$250] QBO - "Required" remains enabled when all tags are disabled[/-] [+][HOLD for payment 2024-07-24] [$250] QBO - "Required" remains enabled when all tags are disabled[/+] on Jul 17, 2024

  13. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botBot
    on Jul 17, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot
    removed
    ReviewingHas a PR in review
    on Jul 17, 2024

  15. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botBot
    on Jul 17, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jul 23, 2024
  17. melvin-bot
    assigned
    dylanexpensify
    on Jul 24, 2024

  18. melvin-bot commented on Jul 24, 2024

    @melvin-bot
    melvin-botBot
    on Jul 24, 2024 – with Melvin Bot

    Issue is ready for payment but no BZ is assigned. @dylanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  19. melvin-bot commented on Jul 26, 2024

    @melvin-bot
    melvin-botBot
    on Jul 26, 2024 – with Melvin Bot

    @cead22, @akinwale, @dylanexpensify, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  20. melvin-bot
    added
    Overdue
    on Jul 26, 2024

  21. mallenexpensify commented on Jul 30, 2024

    @mallenexpensify
    mallenexpensify
    on Jul 30, 2024
    Contributor

    Contributor: @Krishna2323 paid $250 via Upwork
    Contributor+: @akinwale paid $250 via Upwork.

    @akinwale plz complete the BZ checklist below?

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@] The PR that introduced the bug has been identified. Link to the PR:
    • [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@] Determine if we should create a regression test for this bug.
    • [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  22. akinwale commented on Jul 30, 2024

    @akinwale
    akinwale
    on Jul 30, 2024
    Contributor
    • [@] The PR that introduced the bug has been identified. Link to the PR:
    • [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Not a regression. The specific functionality was not implemented.

    • [@] Determine if we should create a regression test for this bug.
    • [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Steps
    Precondition: Account is connected to QBO

    1. Launch Expensify.
    2. Navigate to the settings for the workspace connected to QBO.
    3. Navigate to Tags.
    4. Toggle the Required switch.
    5. Select all tags.
    6. Disable all tags.
    7. Verify that the "Required" switch is disabled and locked when all tags are disabled.

    Do we agree 👍 or 👎?

  23. melvin-bot
    removed
    Overdue
    on Jul 30, 2024

  24. mallenexpensify commented on Jul 30, 2024

    @mallenexpensify
    mallenexpensify
    on Jul 30, 2024
    Contributor

    Thanks @akinwale , test case created!
    https://github.com/Expensify/Expensify/issues/416507

  25. mallenexpensify
    closed this as completedon Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions