Skip to content

[HOLD for payment 2024-08-01] [$250] mWeb – Chat – Workspace switcher is with blue border after login #43713

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+jp_e_category_1@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log out
  3. Log in
  4. Observe Workspace switcher in the left top part

Expected Result:

Workspace switcher is without blue border after login

Actual Result:

Workspace switcher is with blue border after login

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512187_1718296681964.Blue_b.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0140196526c3a485da
  • Upwork Job ID: 1803111339129290564
  • Last Price Increase: 2024-07-16
  • Automatic offers:
    • hoangzinh | Reviewer | 103161579
    • tsa321 | Contributor | 103161581
Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  2. melvin-bot commented on Jun 13, 2024

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 13, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 13, 2024

    @lanitochka17
    Author

    @tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jun 13, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  6. tylerkaraszewski commented on Jun 13, 2024

    @tylerkaraszewski
    Contributor

    I can't reproduce this.

    RPReplay_Final1718305035.mp4
  7. luacmartins commented on Jun 13, 2024

    @luacmartins
    Contributor

    This is likely coming from #39520. It's really minor though

  8. luacmartins commented on Jun 13, 2024

    @luacmartins
    Contributor

    @lanitochka17 can you ask for a re-test? In the meantime, I'll demote this to NAB since it doesn't break any features.

  9. removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 13, 2024
  10. 64 remaining items

  11. melvin-bot commented on Jul 24, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 25, 2024
  13. changed the title [-][$250] mWeb – Chat – Workspace switcher is with blue border after login[/-] [+][HOLD for payment 2024-08-01] [$250] mWeb – Chat – Workspace switcher is with blue border after login[/+] on Jul 25, 2024
  14. melvin-bot commented on Jul 25, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jul 25, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-01. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Aug 1, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  17. hoangzinh commented on Aug 2, 2024

    @hoangzinh
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR: Add focus trap #39520
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add focus trap #39520 (comment)
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug: ⛔ No it's a minor UI issue. User can still use app normally.
  18. twisterdotcom commented on Aug 2, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions