You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-01] [$250] mWeb – Chat – Workspace switcher is with blue border after login #43713
Version Number: 1.4.83-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+jp_e_category_1@applause.expensifail.com Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-][$250] mWeb – Chat – Workspace switcher is with blue border after login[/-][+][HOLD for payment 2024-08-01] [$250] mWeb – Chat – Workspace switcher is with blue border after login[/+]on Jul 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
The PR that introduced the bug has been identified. Link to the PR: Add focus trap #39520
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add focus trap #39520 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: ⛔ No it's a minor UI issue. User can still use app normally.
Activity
melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to @tylerkaraszewski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 13, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 13, 2024
@tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 13, 2024
We think that this bug might be related to #vip-vsp
tylerkaraszewski commentedon Jun 13, 2024
I can't reproduce this.
RPReplay_Final1718305035.mp4
luacmartins commentedon Jun 13, 2024
This is likely coming from #39520. It's really minor though
luacmartins commentedon Jun 13, 2024
@lanitochka17 can you ask for a re-test? In the meantime, I'll demote this to NAB since it doesn't break any features.
64 remaining items
melvin-bot commentedon Jul 24, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][$250] mWeb – Chat – Workspace switcher is with blue border after login[/-][+][HOLD for payment 2024-08-01] [$250] mWeb – Chat – Workspace switcher is with blue border after login[/+]melvin-bot commentedon Jul 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-01. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 1, 2024
Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
hoangzinh commentedon Aug 2, 2024
BugZero Checklist:
twisterdotcom commentedon Aug 2, 2024
Payment Summary: