You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for Payment 2024-08-22] [$250] Submit expense - Tabs disappear when changing from Scan to Distance via SHIFT+TAB #43719
Version Number: 1.4.83-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4626993 Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to FAB > Submit expense
Go to Scan
Click on empty area on the RHP (like the empty header area)
Press SHIFT+TAB
Expected Result:
Nothing will happen
Actual Result:
RHP changes to Distance flow, and tabs (Manual, Scan, Distance) are missing
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
The production deploy automation failed: This should be on [HOLD for Payment 2024-08-22] according to #47356 prod deploy checklist, confirmed in #45982 (comment).
changed the title [-][$250] Submit expense - Tabs disappear when changing from Scan to Distance via SHIFT+TAB[/-][+][HOLD for Payment 2024-08-22] [$250] Submit expense - Tabs disappear when changing from Scan to Distance via SHIFT+TAB[/+]on Aug 21, 2024
Thanks @rayane-djouah - since the automation failed. I'll posted the checklist below 😄
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
The PR that introduced the bug has been identified. Link to the PR: Add focus trap #39520
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add focus trap #39520 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Open the app on web / desktop
Go to FAB > Submit expense
Verify that tab navigation works correctly
Verify that the focus jumps around the page but there's no UI shifting (Page tabs should not disappear)
Click on empty area on the RHP (like the empty header area)
Press SHIFT+TAB
Verify that there's no UI shifting (Page tabs should not disappear)
Activity
melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to @tgolen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 13, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 13, 2024
@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 13, 2024
We think that this bug might be related to #vip-vsp
105 remaining items
melvin-bot commentedon Jul 22, 2024
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
OfstadC commentedon Aug 1, 2024
Any update here @dominictb @rayane-djouah ? 😃
rayane-d commentedon Aug 2, 2024
PR under review
melvin-bot commentedon Aug 14, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
rayane-d commentedon Aug 20, 2024
This ^ is a false positive #47381 (comment)
rayane-d commentedon Aug 20, 2024
Note
The production deploy automation failed: This should be on [HOLD for Payment 2024-08-22] according to #47356 prod deploy checklist, confirmed in #45982 (comment).
cc @OfstadC
[-][$250] Submit expense - Tabs disappear when changing from Scan to Distance via SHIFT+TAB[/-][+][HOLD for Payment 2024-08-22] [$250] Submit expense - Tabs disappear when changing from Scan to Distance via SHIFT+TAB[/+]OfstadC commentedon Aug 21, 2024
Thanks @rayane-djouah - since the automation failed. I'll posted the checklist below 😄
rayane-d commentedon Aug 22, 2024
Checklist
Regression Test Proposal
Do we agree 👍 or 👎
cc @OfstadC
OfstadC commentedon Aug 22, 2024
Payment Summary: