Repository navigation
[PAID] [$500] Keyboard focus is on the "close" button when uploading an attachment #43726
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.83-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718296177557209
Action Performed:
- Go to staging.new.expensify.com
- Open any report and add attachment
- Press "enter" key on keyboard
Expected Result:
Keyboard focus on "Send" button and image sent
Actual Result:
Keyboard focus on cancel button and pressing "enter" on keyboard cancels the upload
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Recording.211.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ab436ac7382c9793
- Upwork Job ID: 1802770011901307524
- Last Price Increase: 2024-07-08
- Automatic offers:
- rojiphil | Reviewer | 103095843
- suneox | Contributor | 103095845
Activity
melvin-bot commentedon Jun 13, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.tsa321 commentedon Jun 13, 2024
Cannot reproduce in production release.
offending PR: #39520
tsa321 commentedon Jun 14, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Keyboard focus is on the "close" button when uploading an attachment
What is the root cause of that problem?
We introduce focusTrap in #39520
But in react-native-modal we already have focusTrap:
https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/Modal/ModalFocusTrap.js
What changes do you think we should make in order to solve the problem?
We can remove the new focusTrap and use react native web focusTrap in baseModal which is already there. So we only need to remove
FocusTrapForModal:App/src/components/Modal/BaseModal.tsx
Line 256 in e306af7
Another alternative solution is to include the attachment screen in:
include the coresponding attachment modal screen in
SCREENS_WITH_AUTOFOCUS.App/src/components/FocusTrap/SCREENS_WITH_AUTOFOCUS.ts
Line 4 in 2a641d9
[-]Keyboard focus is on the "close" button when uploading an attachment[/-][+][$250] Keyboard focus is on the "close" button when uploading an attachment[/+]melvin-bot commentedon Jun 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01ab436ac7382c9793
melvin-bot commentedon Jun 17, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (
External)CortneyOfstad commentedon Jun 17, 2024
I was able to recreate so going to get some eyes on this. @rojiphil we have a proposal here for review when you have a chance!
63 remaining items
CortneyOfstad commentedon Jul 31, 2024
@rojiphil / @suneox please complete the checklist as soon as you can so there is no delay in payment being issued! Thanks!
@strepanier03 I am heading OoO so reassigning so there is no delay in issuing the payment tomorrow. Thank you!
suneox commentedon Aug 1, 2024
@rojiphil Could you please complete the checklist since you’re the reviewer for this issue?
strepanier03 commentedon Aug 1, 2024
I'll check tomorrow for the checklist. I'm heading out soon.
rojiphil commentedon Aug 3, 2024
focusTrapForModalare generic and can impact other modals, it is better to have a regression testTest
1 Copy image to clipboard
2 Open any report
3 Paste image to the composer input by hotkey (Ctrl+V)
4 Press 'Enter' key to send the message
5 Verify that the image is sent
rojiphil commentedon Aug 3, 2024
@strepanier03 @CortneyOfstad
Completed BZ checklist and accepted offer.
Thanks and sorry for the delayed response.
melvin-bot commentedon Aug 5, 2024
@rojiphil, @strepanier03, @CortneyOfstad, @suneox, @grgia Eep! 4 days overdue now. Issues have feelings too...
strepanier03 commentedon Aug 5, 2024
Both contracts are paid and closed in Upwork. Thank you all!
[-][HOLD for payment 2024-08-01] [$500] Keyboard focus is on the "close" button when uploading an attachment[/-][+][PAID] [$500] Keyboard focus is on the "close" button when uploading an attachment[/+]