You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] mWeb-Distance rate-From more features page tapping back directed to distance rate #43755
Version Number: 1. 4.83 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
changed the title [-]mWeb-Distance rate-From more features page tapping back directed to distance rate[/-][+][$250] mWeb-Distance rate-From more features page tapping back directed to distance rate[/+]on Jun 18, 2024
Doing it this way will make sure the Distance Rate page was popped from the navigation stack and when going back from More Features page, it will correctly go back to the Settings page
Optional: 2nd param shouldEnforceFallback could be put as true
What alternative solutions did you explore? (Optional)
Use Navigation.resetToHome(); to reset the navigation state correctly, after that navigate to the more features page
So this will be updated to
Another idea is to manually pop the navigation route until we meet the Settings page (can be as simple as going back twice first), then navigate to more features page
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav] Determine if we should create a regression test for this bug.
[@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-07-17] [$250] mWeb-Distance rate-From more features page tapping back directed to distance rate[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] mWeb-Distance rate-From more features page tapping back directed to distance rate[/+]on Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav] Determine if we should create a regression test for this bug.
[@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
This is ready for payout today @sonialiap. I checked and goBack logic was more like an edge case. I don't think we need a regression test for this one.
Activity
melvin-bot commentedon Jun 14, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 17, 2024
@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]mWeb-Distance rate-From more features page tapping back directed to distance rate[/-][+][$250] mWeb-Distance rate-From more features page tapping back directed to distance rate[/+]melvin-bot commentedon Jun 18, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01dbdf127f2f018440
melvin-bot commentedon Jun 18, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)dominictb commentedon Jun 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
From more features page tapping back user directed to distance rate instead settings
What is the root cause of that problem?
In https://github.com/Expensify/App/blob/main/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx#L143-L144, the app uses
navigateso the Distance Rate page will still remain in the navigation stack, so when go back it will go back to it.What changes do you think we should make in order to solve the problem?
Replace https://github.com/Expensify/App/blob/main/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx#L143-L144 with
Doing it this way will make sure the Distance Rate page was popped from the navigation stack and when going back from More Features page, it will correctly go back to the Settings page
Optional: 2nd param
shouldEnforceFallbackcould be put astrueWhat alternative solutions did you explore? (Optional)
Use
Navigation.resetToHome();to reset the navigation state correctly, after that navigate to the more features pageSo this will be updated to
Another idea is to manually pop the navigation route until we meet the Settings page (can be as simple as going back twice first), then navigate to more features page
20 remaining items
melvin-bot commentedon Jul 10, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-07-17] [$250] mWeb-Distance rate-From more features page tapping back directed to distance rate[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] mWeb-Distance rate-From more features page tapping back directed to distance rate[/+]melvin-bot commentedon Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mananjadhav commentedon Jul 16, 2024
This is ready for payout today @sonialiap. I checked and
goBacklogic was more like an edge case. I don't think we need a regression test for this one.sonialiap commentedon Jul 18, 2024
Payment summary:
JmillsExpensify commentedon Jul 19, 2024
$250 approved for @mananjadhav