Skip to content

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] mWeb-Distance rate-From more features page tapping back directed to distance rate #43755

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1. 4.83
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap profile icon -- Workspaces -- Workspace
  3. Tap more features
  4. Toggle on distance rate
  5. Tap settings
  6. Tap more features link
  7. Tap app back button

Expected Result:

From more features page tapping back user must be directed to settings page

Actual Result:

From more features page tapping back user directed to distance rate instead settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512765_1718345998466.Screenrecorder-2024-06-14-11-43-53-154_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dbdf127f2f018440
  • Upwork Job ID: 1803050291810403386
  • Last Price Increase: 2024-06-18
  • Automatic offers:
    • dominictb | Contributor | 102856221
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 14, 2024
  2. melvin-bot commented on Jun 14, 2024

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jun 17, 2024

    @melvin-bot

    @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 18, 2024
  5. changed the title [-]mWeb-Distance rate-From more features page tapping back directed to distance rate[/-] [+][$250] mWeb-Distance rate-From more features page tapping back directed to distance rate[/+] on Jun 18, 2024
  6. melvin-bot commented on Jun 18, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 18, 2024
  8. melvin-bot commented on Jun 18, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  9. dominictb commented on Jun 18, 2024

    @dominictb
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    From more features page tapping back user directed to distance rate instead settings

    What is the root cause of that problem?

    In https://github.com/Expensify/App/blob/main/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx#L143-L144, the app uses navigate so the Distance Rate page will still remain in the navigation stack, so when go back it will go back to it.

    What changes do you think we should make in order to solve the problem?

    Replace https://github.com/Expensify/App/blob/main/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx#L143-L144 with

    Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID));
    

    Doing it this way will make sure the Distance Rate page was popped from the navigation stack and when going back from More Features page, it will correctly go back to the Settings page

    Optional: 2nd param shouldEnforceFallback could be put as true

    What alternative solutions did you explore? (Optional)

    Use Navigation.resetToHome(); to reset the navigation state correctly, after that navigate to the more features page
    So this will be updated to

    Navigation.resetToHome();
    Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID));
    

    Another idea is to manually pop the navigation route until we meet the Settings page (can be as simple as going back twice first), then navigate to more features page

  10. 20 remaining items

  11. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-17. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
    • [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mananjadhav] Determine if we should create a regression test for this bug.
    • [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. changed the title [-][HOLD for payment 2024-07-17] [$250] mWeb-Distance rate-From more features page tapping back directed to distance rate[/-] [+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] mWeb-Distance rate-From more features page tapping back directed to distance rate[/+] on Jul 15, 2024
  15. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-22. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
    • [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mananjadhav] Determine if we should create a regression test for this bug.
    • [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. mananjadhav commented on Jul 16, 2024

    @mananjadhav
    Collaborator

    This is ready for payout today @sonialiap. I checked and goBack logic was more like an edge case. I don't think we need a regression test for this one.

  18. sonialiap commented on Jul 18, 2024

    @sonialiap
    Contributor

    Payment summary:

  19. JmillsExpensify commented on Jul 19, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions