Repository navigation
[HOLD for payment 2024-07-10] Composer is not highlighted when focused after enabling toggle and clicking + button #43766
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.83-1
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
- Go to staging.new.expensify.com
- Go to any chat.
- Focus on the composer.
- Note that the composer is higlighted when it is in focus.
- Go to Account settings > Troubleshoot.
- Enable any toggle from Troubleshoot.
- Return to chat.
- Note that the composer is still in focus.
- Click composer + button.
- Click on the composer.
- Note that the composer is not highlighted when it is in focus.
- Copy paste any content in the composer while it is focused and not highlighted.
- Note that the cursor appears before the text after pasting it.
Expected Result:
The composer should be highlighted when it is in focus at all time.
Actual Result:
In Step 11, the composer is not focused after switching on the toggle from Troubleshoot, clicking composer + button and refocusing on the composer.
Text cursor is not positioning properly after pasting content when the composer is in this state (Step 13).
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Jun 14, 2024
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 14, 2024
Triggered auto assignment to @puneetlath (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 14, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Jun 14, 2024
@isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Jun 14, 2024
We think this issue might be related to the #vip-vsb
izarutskaya commentedon Jun 14, 2024
Production
bandicam.2024-06-14.14-04-05-563.mp4
20 remaining items
melvin-bot commentedon Jul 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
puneetlath commentedon Jul 3, 2024
@aimane-chnaif was the C+ here.
isabelastisser commentedon Jul 8, 2024
@aimane-chnaif, please complete the checklist above. Thanks!
aimane-chnaif commentedon Jul 9, 2024
Offending PR is #39520 which was quite big, so hard to catch this kind of bugs.
This was minor visual bug and QA team caught this on staging so no need regression test.
isabelastisser commentedon Jul 10, 2024
@aimane-chnaif / C+ review / $250 paid in Upwork.
@jnowakow / contributor / no payment required (contractor).
aimane-chnaif commentedon Oct 3, 2024
@isabelastisser I am still using upwork. Can you please reopen and sort payment? Thanks
isabelastisser commentedon Oct 8, 2024
@aimane-chnaif, I hired you in Upwork now.
aimane-chnaif commentedon Oct 23, 2024
Accepted thanks