Repository navigation
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Chat - "as copilot for" is displayed in avatar tooltip #43800
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.8-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
- Go to staging.new.expensify.com
- Go to any chat.
- Send a message.
- Hover over self avatar.
Expected Result:
The tooltip for self avatar will just display the user name.
Actual Result:
The tooltip for self avatar displays "as copilot for x".
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Jun 15, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 15, 2024
Triggered auto assignment to @luacmartins (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 15, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jun 15, 2024
@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
m-natarajan commentedon Jun 15, 2024
We think that this bug might be related to #vip-vsb
neonbhai commentedon Jun 15, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
"as copilot for" is displayed in avatar tooltip
What is the root cause of that problem?
Since now the default value for Onyx is '-1' this statement evaluates to
truewhen delegate is not present.App/src/components/UserDetailsTooltip/BaseUserDetailsTooltip/index.tsx
Line 34 in 75c104b
What changes do you think we should make in order to solve the problem?
We will add a check for
-1here:App/src/components/UserDetailsTooltip/BaseUserDetailsTooltip/index.tsx
Line 34 in 75c104b
24 remaining items
[-][HOLD for payment 2024-06-24] Chat - "as copilot for" is displayed in avatar tooltip[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Chat - "as copilot for" is displayed in avatar tooltip[/+]melvin-bot commentedon Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
melvin-bot commentedon Jun 21, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
MitchExpensify commentedon Jun 24, 2024
Ah yes, offer sent here: https://www.upwork.com/nx/wm/offer/102848809
mountiny commentedon Jun 24, 2024
@neonbhai have you confirmed?
I dont think we need a regression test for this
neonbhai commentedon Jun 24, 2024
Thank you, accepted the offer!
cc: @MitchExpensify @mountiny
melvin-bot commentedon Jun 27, 2024
@mountiny, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jun 28, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Jul 1, 2024
@mountiny, @MitchExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
MitchExpensify commentedon Jul 1, 2024
Paid and contract ended!