Repository navigation
[$250] Don't allow the Approver on a policy to leave a workspace chat #43852
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.84-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
- User is invited to a workspace
- Go to staging.new.expensify.com
- Go to workspace chat as workspace member
- Go offline
- Go to + > Submit expense > Manual
- Proceed to confirmation page
- Click on the workspace chat
- Click Leave
Expected Result:
The option to leave should not show up for a workspace chat unless you were invited into the room by a mention and not part of the approval workflow
Actual Result:
You see the option to leave the room
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
20240618_000151.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0194a281c56dd7cd3e
- Upwork Job ID: 1802768531325940224
- Last Price Increase: 2024-07-08
Activity
melvin-bot commentedon Jun 17, 2024
Triggered auto assignment to @thienlnam (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 17, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 17, 2024
@thienlnam FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 17, 2024
We think that this bug might be related to #wave-collect - Release 1
thienlnam commentedon Jun 17, 2024
This seemed like it would have been from a BE PR, but I haven't seen anything that would change how this works. Going to open up externally for some more eyes on the App checklist
melvin-bot commentedon Jun 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0194a281c56dd7cd3e
[-]Expense - Expense can still be submitted after leaving workspace chat[/-][+][$250] Expense - Expense can still be submitted after leaving workspace chat[/+]44 remaining items
melvin-bot commentedon Jul 4, 2024
@sobitneupane, @thienlnam, @isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!
isabelastisser commentedon Jul 8, 2024
Bump @mvtglobally, can you please retest? Thanks!
melvin-bot commentedon Jul 8, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Jul 8, 2024
@sobitneupane, @thienlnam, @isabelastisser 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
sobitneupane commentedon Jul 9, 2024
#43852 (comment)
isabelastisser commentedon Jul 10, 2024
Bump @mvtglobally. can you please retest? thanks!
mvtglobally commentedon Jul 11, 2024
Issue not reproducible during KI retests. (Second week)
kbecciv commentedon Jul 11, 2024
Here is a video, issue no longer reproducible
Screen.Recording.2024-07-10.at.9.39.38.PM.mp4