Repository navigation
[HOLD for payment 2024-08-13] [$500] Desktop - "Check for update" never actually shows option to update the Desktop app #44097
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.86-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): emilio.utest@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Access the New Expensify Beta app
- Sign into a valid account
- Go to "New Expensify app" in the header > Check for Update > Wait for Update
Expected Result:
User expects the Desktop app to update and receive a message stating that the update is ready
Actual Result:
The user never receives an Update ready message and to update the user needs to access the build link from web
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6519521_1718896885781.Can_not_update_Desktop_app_.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~012dcff6435623d64e
- Upwork Job ID: 1803850854977228837
- Last Price Increase: 2024-06-28
- Automatic offers:
- dukenv0307 | Reviewer | 102945241
Issue Owner
Current Issue Owner: @mallenexpensifyMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Jun 20, 2024
Triggered auto assignment to @neil-marcellini (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 20, 2024
@neil-marcellini FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
neil-marcellini commentedon Jun 20, 2024
@lanitochka17 the description says that this is reproducible on staging and production, therefore it should not be a deploy blocker. Is that true? I'll try testing myself on prod but IDK if I'll be able to reproduce it in a timely manner.
[-]Desktop - "Check for update" never actually shows option to update the Desktop app[/-][+][$250] Desktop - "Check for update" never actually shows option to update the Desktop app[/+]melvin-bot commentedon Jun 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~012dcff6435623d64e
91 remaining items
[-][$500] Desktop - "Check for update" never actually shows option to update the Desktop app[/-][+][HOLD for payment 2024-08-13] [$500] Desktop - "Check for update" never actually shows option to update the Desktop app[/+]melvin-bot commentedon Aug 6, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 6, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Aug 11, 2024
Checklist provided above ^ For the second bug there is no offending PR as the bug was upstream
mallenexpensify commentedon Aug 12, 2024
@s77rt we'd still want a regression test for this though, right? I feel like this bug has occurred multiple times already, if it were to happen again, it'd be best to catch it during testing vs waiting for someone tor report.
s77rt commentedon Aug 13, 2024
@mallenexpensify I would say this requires a regression test but it's not clear if the QA can perform the test. The QA team tests on staging and if they are on staging they can't update the app (they are already on the latest).
mallenexpensify commentedon Aug 13, 2024
Thanks @s77rt , can you propose the steps and I'll create the TestRail case update? If QA can't test, they can comment on the issue and close if needed.
s77rt commentedon Aug 13, 2024
@mallenexpensify
Regression Test Proposal
Prerequires: Desktop App that can be updated (i.e. current version is not the latest)
mallenexpensify commentedon Aug 13, 2024
Thanks @s77rt , TestRail GH created.
https://github.com/Expensify/Expensify/issues/420213