Skip to content

[Payment Card / Subscription] iOS - "Add Payment Card" button is blinking when changing currency in app #44118

New issue
New issue
Closed
Closed
[Payment Card / Subscription] iOS - "Add Payment Card" button is blinking when changing currency in app#44118
Assignees
blimpichnarefyev91
Labels
DailyKSv2Engineering

Description

@lanitochka17
lanitochka17
opened on Jun 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.86-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): emilio.utest@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #43317

Action Performed:

  1. Access the New Expensify Beta app
  2. Sign into a valid account
  3. Go to staging.new.expensify.com/settings/subscription/add-payment-card (You may need a beta access account to locate this page)
  4. Change the currency and observe the bottom green button

Expected Result:

User expects the button to stay normal when changing currency

Actual Result:

The button is flashing when the currency is changed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6519757_1718912768810.Subscription_button_is_blinking_on_iOS_app_.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @narefyev91

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 20, 2024
  2. melvin-bot
    assigned
    thienlnam
    on Jun 20, 2024

  3. melvin-bot commented on Jun 20, 2024

    @melvin-bot
    melvin-botBot
    on Jun 20, 2024 – with Melvin Bot

    Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    on Jun 20, 2024

  5. github-actions commented on Jun 20, 2024

    @github-actions
    github-actionsBot
    on Jun 20, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mountiny
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    DeployBlockerIndicates it should block deploying the API
    on Jun 20, 2024
  7. mountiny
    added this to [#whatsnext] #wave-collecton Jun 20, 2024

  8. mountiny commented on Jun 20, 2024

    @mountiny
    mountiny
    on Jun 20, 2024
    Contributor

    @fabioh8010 this is still behind beta so not a blocker but should be handled

  9. mountiny
    moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collecton Jun 20, 2024
  10. mountiny
    moved this from Release 2: Summer 2024 (Aug) to Polish in [#whatsnext] #wave-collecton Jun 20, 2024

  11. 5 remaining items

  12. trjExpensify commented on Jun 20, 2024

    @trjExpensify
    trjExpensify
    on Jun 20, 2024
    Contributor

    Assigned!

  13. blimpich
    assigned
    blimpich
    and unassigned
    thienlnam
    on Jun 21, 2024

  14. blimpich commented on Jun 21, 2024

    @blimpich
    blimpich
    on Jun 21, 2024
    Contributor

    Picking this up as I'm managing the other issues that are being addressed by this PR, figured I should pick this up too.

  15. melvin-bot commented on Jun 25, 2024

    @melvin-bot
    melvin-botBot
    on Jun 25, 2024 – with Melvin Bot

    @blimpich, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. melvin-bot
    added
    Overdue
    on Jun 25, 2024

  17. melvin-bot commented on Jun 27, 2024

    @melvin-bot
    melvin-botBot
    on Jun 27, 2024 – with Melvin Bot

    @blimpich, @narefyev91 Huh... This is 4 days overdue. Who can take care of this?

  18. blimpich commented on Jun 27, 2024

    @blimpich
    blimpich
    on Jun 27, 2024
    Contributor

    not overdue, PR was merged, waiting auto-close

  19. melvin-bot commented on Jul 1, 2024

    @melvin-bot
    melvin-botBot
    on Jul 1, 2024 – with Melvin Bot

    @blimpich, @narefyev91 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  20. melvin-bot commented on Jul 3, 2024

    @melvin-bot
    melvin-botBot
    on Jul 3, 2024 – with Melvin Bot

    @blimpich, @narefyev91 10 days overdue. Is anyone even seeing these? Hello?

  21. melvin-bot commented on Jul 5, 2024

    @melvin-bot
    melvin-botBot
    on Jul 5, 2024 – with Melvin Bot

    @blimpich, @narefyev91 12 days overdue. Walking. Toward. The. Light...

  22. blimpich commented on Jul 5, 2024

    @blimpich
    blimpich
    on Jul 5, 2024
    Contributor

    Closing as the fix for this reached production.

  23. blimpich
    closed this as completedon Jul 5, 2024
  24. melvin-bot
    removed
    Overdue
    on Jul 5, 2024
  25. github-project-automation
    moved this from Polish to Done in [#whatsnext] #wave-collecton Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DailyKSv2Engineering

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions