[HOLD for payment 2024-07-26] [$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline

@OfstadC

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.0-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4652159
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Workspace has a few distance rates

Go to staging.new.expensify.com
Go to workspace settings > Distance rates
Go offline
Delete one of the distance rates
Go to workspace chat
Submit a distance expense with the deleted distance rate
Go online

Expected Result:

In Step 6, app should prevent the deleted distance rate from being selected when submitting a distance distance

Actual Result:

In Step 6, user can submit a distance expense with the deleted distance rate, which results in error when returning online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6520132_1718947996614.20240621_132706.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ad6ccc1c574e1a03
Upwork Job ID: 1810478926161920694
Last Price Increase: 2024-07-09
Automatic offers:

shubham1206agra | Reviewer | 103049061
paultsimura | Contributor | 103049063

Issue Owner

Current Issue Owner: @OfstadC

@OfstadC

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@OfstadC

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

We can still select pending-delete distance rate and will result in an error when submitted.

What is the root cause of that problem?

We are not filtering any distance rate that is pending-delete when showing the rate list.

App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

Lines 62 to 72 in 68374a5

    
           const sections = Object.values(rates).map((rate) => { 
        
               const rateForDisplay = DistanceRequestUtils.getRateForDisplay(rate.unit, rate.rate, rate.currency, translate, toLocaleDigit); 
        
               return { 
        
                   text: rate.name ?? rateForDisplay, 
        
                   alternateText: rate.name ? rateForDisplay : '', 
        
                   keyForList: rate.customUnitRateID, 
        
                   value: rate.customUnitRateID, 
        
                   isSelected: lastSelectedRateID ? lastSelectedRateID === rate.customUnitRateID : !!(rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE), 
        
               }; 
        
           });

What changes do you think we should make in order to solve the problem?

Filter out any pending-delete rate. To do that:

Return the pendingAction from getMileageRates

App/src/libs/DistanceRequestUtils.ts

Lines 59 to 65 in 68374a5

    
           mileageRates[rateID] = { 
        
               rate: rate.rate, 
        
               currency: rate.currency, 
        
               unit: distanceUnit.attributes.unit, 
        
               name: rate.name, 
        
               customUnitRateID: rate.customUnitRateID, 
        
           };

pendingAction: rate.pendingAction,

Filter out rate with pending action of delete.

App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

Line 62 in 68374a5

const sections = Object.values(rates).map((rate) => {

.filter(rate => rate.pendingAction !== 'delete')

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rates- Deleted distance rate is not disabled when submitting distance expense offline

What is the root cause of that problem?

We don't have any check for disabled rates on IOURequestStepDistanceRate page.

App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

Lines 62 to 72 in 68374a5

    
           const sections = Object.values(rates).map((rate) => { 
        
               const rateForDisplay = DistanceRequestUtils.getRateForDisplay(rate.unit, rate.rate, rate.currency, translate, toLocaleDigit); 
        
               return { 
        
                   text: rate.name ?? rateForDisplay, 
        
                   alternateText: rate.name ? rateForDisplay : '', 
        
                   keyForList: rate.customUnitRateID, 
        
                   value: rate.customUnitRateID, 
        
                   isSelected: lastSelectedRateID ? lastSelectedRateID === rate.customUnitRateID : !!(rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE), 
        
               }; 
        
           });

What changes do you think we should make in order to solve the problem?

We need to first return pendingAction field from getMileageRates.

        mileageRates[rateID] = {
            rate: rate.rate,
            currency: rate.currency,
            unit: distanceUnit.attributes.unit,
            name: rate.name,
            customUnitRateID: rate.customUnitRateID,
            pendingAction: rate.pendingAction,
        };

Then add isDisabled and pendingAction.

        return {
            text: rate.name ?? rateForDisplay,
            alternateText: rate.name ? rateForDisplay : '',
            keyForList: rate.customUnitRateID,
            value: rate.customUnitRateID,
            isSelected: lastSelectedRateID ? lastSelectedRateID === rate.customUnitRateID : !!(rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE),
            isDisabled: rate.pendingAction === 'delete',
            pendingAction: rate.pendingAction,
        };

What alternative solutions did you explore? (Optional)

If we also need to grey out the option when updated offline, we nee to also return pendingFields from getMileageRates and update the pendingAction property like we do in PolicyDistanceRatesPage.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Lines 113 to 118 in 68374a5

    
           pendingAction: 
        
               value.pendingAction ?? 
        
               value.pendingFields?.rate ?? 
        
               value.pendingFields?.enabled ?? 
        
               value.pendingFields?.currency ?? 
        
               (policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),

    const sections = Object.values(rates).map((rate) => {
        const rateForDisplay = DistanceRequestUtils.getRateForDisplay(rate.unit, rate.rate, rate.currency, translate, toLocaleDigit);

        return {
            text: rate.name ?? rateForDisplay,
            alternateText: rate.name ? rateForDisplay : '',
            keyForList: rate.customUnitRateID,
            value: rate.customUnitRateID,
            isSelected: lastSelectedRateID ? lastSelectedRateID === rate.customUnitRateID : !!(rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE),
            isDisabled: rate.pendingAction === 'delete',
            pendingAction:
                rate.pendingAction ??
                rate.pendingFields?.rate ??
                rate.pendingFields?.enabled ??
                rate.pendingFields?.currency ??
                (policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),
        };
    });

Proposal Updated

Removed redundant code.

Proposal Updated

We also need to add pendingAction: rate.pendingAction for correct styling.

Proposal Updated

Added alternative

Following this Slack thread before proceeding

@mallenexpensify

@mallenexpensify I wonder if the Offline Distance request issues should be consolidated since they might have the same/similar solution? 🤔

@paultsimura

Payment Summary:

Paid @paultsimura $250 via Upwork
Matt A. paid @shubham1206agra $250 via Upwork.

@OfstadC

@OfstadC Offer accepted

@shubham1206agra

@shubham1206agra paid via Upwork, payment confirmation updated above. @shubham1206agra plz complete the BZ checklist above.

@arosiclair

@arosiclair, @OfstadC, @paultsimura, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

@shubham1206agra

@shubham1206agra I think you still need to complete the checklist

@shubham1206agra

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: feat: policy distance rates edit #38237
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/38237/files#r1697154647
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@shubham1206agra] Determine if we should create a regression test for this bug. No
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@shubham1206agra

@shubham1206agra do we want a test case for this? If so, please provide the steps. If not, please provide reasoning why not. Thx

@mallenexpensify

@mallenexpensify We don't need any test steps here as this was an edge case that we missed during initial implementation, and the bug should not happen again in future.

@arosiclair

@arosiclair, @OfstadC, @paultsimura, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-26] [$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline #44154

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal Updated

Proposal Updated

Proposal Updated

47 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const sections = Object.values(rates).map((rate) => {
	const rateForDisplay = DistanceRequestUtils.getRateForDisplay(rate.unit, rate.rate, rate.currency, translate, toLocaleDigit);

	return {
	text: rate.name ?? rateForDisplay,
	alternateText: rate.name ? rateForDisplay : '',
	keyForList: rate.customUnitRateID,
	value: rate.customUnitRateID,
	isSelected: lastSelectedRateID ? lastSelectedRateID === rate.customUnitRateID : !!(rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE),
	};
	});

	mileageRates[rateID] = {
	rate: rate.rate,
	currency: rate.currency,
	unit: distanceUnit.attributes.unit,
	name: rate.name,
	customUnitRateID: rate.customUnitRateID,
	};

	pendingAction:
	value.pendingAction ??
	value.pendingFields?.rate ??
	value.pendingFields?.enabled ??
	value.pendingFields?.currency ??
	(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),

[HOLD for payment 2024-07-26] [$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline #44154

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 21, 2024

lanitochka17 commented on Jun 21, 2024

lanitochka17 commented on Jun 21, 2024

bernhardoj commented on Jun 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Krishna2323 commented on Jun 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Krishna2323 commented on Jun 21, 2024

Proposal Updated

Krishna2323 commented on Jun 21, 2024

Proposal Updated

Krishna2323 commented on Jun 21, 2024

Proposal Updated

OfstadC commented on Jun 21, 2024

OfstadC commented on Jun 24, 2024

47 remaining items

OfstadC commented on Jul 26, 2024

shubham1206agra commented on Jul 26, 2024

mallenexpensify commented on Jul 26, 2024

melvin-bot commented on Jul 29, 2024

arosiclair commented on Jul 30, 2024

shubham1206agra commented on Jul 30, 2024

mallenexpensify commented on Jul 30, 2024

shubham1206agra commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions