[HOLD for payment 2024-07-22] [Performance] Slow load of one-transaction reports

@VictoriaExpensify

One transaction reports seem to load slower than regular reports or regular transactions. And they have a weird UI while they are loading where the report looks like a one-transaction report, but there is also that same expense attached to the report as a comment.

Let's fix this by fixing the weird UI while loading and making loading faster.

Context here: https://expensify.slack.com/archives/C05LX9D6E07/p1718718047425429?thread_ts=1718652645.370349&cid=C05LX9D6E07

Issue Owner

Current Issue Owner: @VictoriaExpensify / @VictoriaExpensify

@VictoriaExpensify

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Hello it's Tomek from Callstack, I would like to work on that

It looks like there's an error when displaying the ReportAction in ReportActionItem.tsx. Essentially, the app initially renders the previous report and then updates it after it has already been rendered. This issue might be caused by Onyx's optimistic approach, but it seems it could be fixed with a simple condition check. I'm currently investigating this further.

Ok sounds good!

The PR that introduced the bug has been identified. Link to the PR: Add One Transaction Report View #36934
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/36934/files#r1690394149

Regression Test Proposal

Create new Workspace with user A
Invite another member to it - user B
As user A, Go to the Workspace settings > More Features > Enable Workflows
Setup approvals
Set user A as the Approver on the workspace
Log out
Sign in as B
Submit expense in that workspace
Sign in as A and navigate to the chat with B and open the expense report
Navigate back
Open another expense report
Verify that report loads without flickering (no previous report action is seen)

@mkhutornyi

@mkhutornyi - I have invited you to accept the Upwork Job. Please let me know once you have accepted it and I'll fix up your payment.

@puneetlath

@puneetlath, @rinej, @VictoriaExpensify, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mkhutornyi

@mkhutornyi - let me know once you've accepted the offer in Upwork :)

@puneetlath

@puneetlath, @rinej, @VictoriaExpensify, @mkhutornyi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@rinej

Payment Summary:
Contributor: @rinej is from an agency-contributor and not due payment
ROLE: @mkhutornyi paid $250 via [Upwork](Upwork Job)

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-22] [Performance] Slow load of one-transaction reports #44162

23 remaining items

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-22] [Performance] Slow load of one-transaction reports #44162

Description

Activity

melvin-bot commented on Jun 21, 2024

rinej commented on Jun 21, 2024

rinej commented on Jun 24, 2024

puneetlath commented on Jun 24, 2024

23 remaining items

mkhutornyi commented on Jul 24, 2024

Regression Test Proposal

VictoriaExpensify commented on Jul 29, 2024

melvin-bot commented on Aug 1, 2024

VictoriaExpensify commented on Aug 1, 2024

melvin-bot commented on Aug 5, 2024

VictoriaExpensify commented on Aug 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions