Skip to content

[HOLD for payment 2024-08-02] [$125] Web - Workspace - Screen blinks when opening member profile #44192

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Workspaces
  3. Go to any workspace
  4. Go to Members
  5. Click on any member

Expected Result:

The screen will not blink when opening member profile

Actual Result:

The screen blinks when opening member profile

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521352_1719047081090.blink_blink.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013a107b5b6f0f348e
  • Upwork Job ID: 1805160170118380262
  • Last Price Increase: 2024-06-24
Issue OwnerCurrent Issue Owner: @jayeshmangwani

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 22, 2024
  2. melvin-bot commented on Jun 22, 2024

    @melvin-bot

    Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 22, 2024

    @lanitochka17
    Author

    @mountiny FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 24, 2024
  6. melvin-bot commented on Jun 24, 2024

    @melvin-bot
  7. changed the title [-]Web - Workspace - Screen blinks when opening member profile[/-] [+][$250] Web - Workspace - Screen blinks when opening member profile[/+] on Jun 24, 2024
  8. 34 remaining items

  9. melvin-bot commented on Jul 25, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Jul 25, 2024
  11. changed the title [-][$125] Web - Workspace - Screen blinks when opening member profile[/-] [+][HOLD for payment 2024-08-02] [$125] Web - Workspace - Screen blinks when opening member profile[/+] on Jul 25, 2024
  12. jayeshmangwani commented on Aug 1, 2024

    @jayeshmangwani
    Contributor
    • [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: I'm not exactly able to find the lines of code that caused this issue, but I think the issue is coming from the Ideal nav PR.
    • [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@jayeshmangwani] Determine if we should create a regression test for this bug. Yes
    • [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Open App in Web/Desktop
    2. Go to Account settings -> Workspaces
    3. Go to any workspace -> Members
    4. Click on any member
    5. Verify that members list doesn't blink

    Do we agree 👍 or 👎

  13. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @jayeshmangwani owed $125 via NewDot
    • Contributor: @jnowakow is from an agency-contributor and not due payment

    BugZero Checklist (@JmillsExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1805160170118380262/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. JmillsExpensify commented on Aug 2, 2024

    @JmillsExpensify
    Contributor

    Payment summary of $125 is correct. @jayeshmangwani can you submit an expense via NewDot?

  15. jayeshmangwani commented on Aug 5, 2024

    @jayeshmangwani
    Contributor

    Requested as per #44192 (comment)

  16. mallenexpensify commented on Aug 6, 2024

    @mallenexpensify
    Contributor
  17. JmillsExpensify commented on Aug 6, 2024

    @JmillsExpensify
    Contributor

    $125 approved for @jayeshmangwani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions