Skip to content

[Awaiting checklist] [$250] Composer - Cursor Position Resets to Start of Message on Page Refresh #44259

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4661747&group_by=cases:section_id&group_order=asc&group_id=296775
Email or phone of affected tester (no customers): shussain+chrome1@applausemail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open a chat
  2. Write text in composer box
  3. Refresh the page

Expected Result:

Cursor Position Should Not Resets to Start of Message on Page Refresh

Actual Result:

Cursor Position Resets to Start of Message on Page Refresh

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6522559_1719208729219.2024-06-24_10-56-46.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0121d7a8303e8c6df6
  • Upwork Job ID: 1805917059078868913
  • Last Price Increase: 2024-07-03
  • Automatic offers:
    • hoangzinh | Reviewer | 103037350
Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 24, 2024
  2. melvin-bot commented on Jun 24, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Jun 24, 2024

    @lanitochka17
    Author

    @twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Jun 24, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. BartoszGrajdek commented on Jun 25, 2024

    @BartoszGrajdek
    Contributor

    This issue is possibly related to live markdown, please add it to the project 🙏🏻 cc @thienlnam

  6. BartoszGrajdek commented on Jun 26, 2024

    @BartoszGrajdek
    Contributor

    @twisterdotcom I believe this issue could be resolved by external contributors. can we open it up for proposals?

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 26, 2024
  8. melvin-bot commented on Jun 26, 2024

    @melvin-bot
  9. changed the title [-]Composer - Cursor Position Resets to Start of Message on Page Refresh[/-] [+][$250] Composer - Cursor Position Resets to Start of Message on Page Refresh[/+] on Jun 26, 2024
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 26, 2024
  11. melvin-bot commented on Jun 26, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  12. 37 remaining items

  13. twisterdotcom commented on Jul 24, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

    @hoangzinh please complete the checklist.

  14. changed the title [-][HOLD for payment 2024-07-24] [$250] Composer - Cursor Position Resets to Start of Message on Page Refresh[/-] [+][Awaiting checklist] [$250] Composer - Cursor Position Resets to Start of Message on Page Refresh[/+] on Jul 24, 2024
  15. bernhardoj commented on Jul 24, 2024

    @bernhardoj
    Contributor

    Requested in ND.

  16. JmillsExpensify commented on Jul 26, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

  17. hoangzinh commented on Jul 26, 2024

    @hoangzinh
    Contributor

    Regression Test Proposal

    1. Sign in to NewDot
    2. Open any chat
    3. Type a message in the composer
    4. Navigate to another chat
    5. Navigate back to the chat in step 2
    6. Verify that the composer is focused and the cursor is at the end of the draft message

    Do we agree 👍 or 👎

  18. hoangzinh commented on Jul 26, 2024

    @hoangzinh
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR: Migrate Composer. web #23359
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23359/files#r1692999112
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug: ✅ Yes we should
  19. twisterdotcom commented on Jul 26, 2024

    @twisterdotcom
    Contributor

    please propose the regression test steps to ensure the same bug will not reach production again.

  20. hoangzinh commented on Jul 26, 2024

    @hoangzinh
    Contributor

    I posted the Regression Test Proposal here #44259 (comment)

  21. mallenexpensify commented on Jul 26, 2024

    @mallenexpensify
    Contributor
  22. perunt commented on Jul 29, 2024

    @perunt
    Contributor

    Hey folks!

    I came from this PR as I was mentioned here.

    I tested this before the fix on dev(and also on staging, but today, it potentially already has those changes) and noticed that the focus was at the end of the text input.
    After the fix, I tested it again and found that after a refresh, the focus always moves to the end. I'm just curious if an option to preserve the cursor position has been discussed rather than moving it to the end @lanitochka17? If not, what do you think about implementing this feature? @hoangzinh

  23. moved this from MEDIUM to Done in Live Markdownon Jul 29, 2024
  24. hoangzinh commented on Jul 29, 2024

    @hoangzinh
    Contributor

    If not, what do you think about implementing this feature?

    Hi @perunt, It's an interesting idea for me. But I'm unsure if we will prioritize it right now. I think you can post it in Slack as a feature request to collect opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions