You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting checklist] [$250] Composer - Cursor Position Resets to Start of Message on Page Refresh #44259
@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Composer - Cursor Position Resets to Start of Message on Page Refresh[/-][+][$250] Composer - Cursor Position Resets to Start of Message on Page Refresh[/+]on Jun 26, 2024
changed the title [-][HOLD for payment 2024-07-24] [$250] Composer - Cursor Position Resets to Start of Message on Page Refresh[/-][+][Awaiting checklist] [$250] Composer - Cursor Position Resets to Start of Message on Page Refresh[/+]on Jul 24, 2024
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: ✅ Yes we should
I tested this before the fix on dev(and also on staging, but today, it potentially already has those changes) and noticed that the focus was at the end of the text input.
After the fix, I tested it again and found that after a refresh, the focus always moves to the end. I'm just curious if an option to preserve the cursor position has been discussed rather than moving it to the end @lanitochka17? If not, what do you think about implementing this feature? @hoangzinh
If not, what do you think about implementing this feature?
Hi @perunt, It's an interesting idea for me. But I'm unsure if we will prioritize it right now. I think you can post it in Slack as a feature request to collect opinions.
Activity
melvin-bot commentedon Jun 24, 2024
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jun 24, 2024
@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 24, 2024
We think that this bug might be related to #vip-vsp
BartoszGrajdek commentedon Jun 25, 2024
This issue is possibly related to live markdown, please add it to the project 🙏🏻 cc @thienlnam
BartoszGrajdek commentedon Jun 26, 2024
@twisterdotcom I believe this issue could be resolved by external contributors. can we open it up for proposals?
melvin-bot commentedon Jun 26, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0121d7a8303e8c6df6
[-]Composer - Cursor Position Resets to Start of Message on Page Refresh[/-][+][$250] Composer - Cursor Position Resets to Start of Message on Page Refresh[/+]melvin-bot commentedon Jun 26, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)37 remaining items
twisterdotcom commentedon Jul 24, 2024
Payment Summary:
@hoangzinh please complete the checklist.
[-][HOLD for payment 2024-07-24] [$250] Composer - Cursor Position Resets to Start of Message on Page Refresh[/-][+][Awaiting checklist] [$250] Composer - Cursor Position Resets to Start of Message on Page Refresh[/+]bernhardoj commentedon Jul 24, 2024
Requested in ND.
JmillsExpensify commentedon Jul 26, 2024
$250 approved for @bernhardoj
hoangzinh commentedon Jul 26, 2024
Regression Test Proposal
Do we agree 👍 or 👎
hoangzinh commentedon Jul 26, 2024
BugZero Checklist:
twisterdotcom commentedon Jul 26, 2024
hoangzinh commentedon Jul 26, 2024
I posted the Regression Test Proposal here #44259 (comment)
mallenexpensify commentedon Jul 26, 2024
Test case created
perunt commentedon Jul 29, 2024
Hey folks!
I came from this PR as I was mentioned here.
I tested this before the fix on dev(and also on staging, but today, it potentially already has those changes) and noticed that the focus was at the end of the text input.
After the fix, I tested it again and found that after a refresh, the focus always moves to the end. I'm just curious if an option to preserve the cursor position has been discussed rather than moving it to the end @lanitochka17? If not, what do you think about implementing this feature? @hoangzinh
hoangzinh commentedon Jul 29, 2024
Hi @perunt, It's an interesting idea for me. But I'm unsure if we will prioritize it right now. I think you can post it in Slack as a feature request to collect opinions.