Skip to content

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [Awaiting Payment July 15] Update copy based on accounting integration selections #44297

Closed

Description

@jamesdeanexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.1-9 (I'm using Chrome web app staging)
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): james@expensify.com
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: james@expensify.com
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1718987997426219?thread_ts=1718837013.444269&cid=C036QM0SLJK

Action Performed:

  1. Connect a workspace to QuickBooks Online
  2. Click Export > Export company cards as
  3. Toggle the options between Credit card and Debit card to see the screen that results
    (See video below with voiced walkthrough)

Expected Result:

  • When Credit card is selected, we should show Credit card account
  • When Debit card is selected, we should show Bank account
    (See video below with voiced walkthrough)

Actual Result:

  • When Credit card is selected, we currently show Account
  • When Debit card is selected, we currently show Account
    (See video below with voiced walkthrough)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

  • Yes, this is just an improvement

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-06-21_17-29-15.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010acf66c02b3a1adb
  • Upwork Job ID: 1806400515559874340
  • Last Price Increase: 2024-06-27
  • Automatic offers:
    • ikevin127 | Reviewer | 102922722
    • gijoe0295 | Contributor | 102922724
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 24, 2024
  2. melvin-bot commented on Jun 24, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 27, 2024
  4. changed the title [-]Update copy based on accounting integration selections[/-] [+][$250] Update copy based on accounting integration selections[/+] on Jun 27, 2024
  5. melvin-bot commented on Jun 27, 2024

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 27, 2024
  7. melvin-bot commented on Jun 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

  8. melvin-bot commented on Jun 27, 2024

    @melvin-bot

    Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

  9. 23 remaining items

  10. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-17. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. ikevin127 commented on Jul 12, 2024

    @ikevin127
    Contributor
    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:

      No offending PR here as the changes are not related to a bug, but to copy / label changes.

    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A

    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

    • [@ikevin127] Determine if we should create a regression test for this bug.

    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

      No regression test needed here as the changes are not related to a bug, but to copy / label changes.
      Do we agree 👍 or 👎.

  13. ikevin127 commented on Jul 15, 2024

    @ikevin127
    Contributor

    Due to delays in production deploy (internal issue) see PR conversation, we agreed on payment for 15th of July with Beamanator (see comment) given that this issue was simply adding copy / labels and not changing functionality which means the likelyhood for regressions is extremely low.

    Shortly after agreeing on 15th, the production deploy was performed, adding the hold for payment 2 days later on 17th.

    @slafortune Is this going to be paid out today given the information above ?

  14. changed the title [-][HOLD for payment 2024-07-17] [$250] [Awaiting Payment July 15] Update copy based on accounting integration selections[/-] [+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [Awaiting Payment July 15] Update copy based on accounting integration selections[/+] on Jul 15, 2024
  15. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-22. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. ikevin127 commented on Jul 16, 2024

    @ikevin127
    Contributor

    ✅ Checklist already completed in #44297 (comment).
    I guess we're looking at payments being issued tomorrow (17th of July) ?

    cc @slafortune callback to #44297 (comment)

  18. slafortune commented on Jul 18, 2024

    @slafortune
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DesignExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions