You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [Awaiting Payment July 15] Update copy based on accounting integration selections #44297
changed the title [-]Update copy based on accounting integration selections[/-][+][$250] Update copy based on accounting integration selections[/+]on Jun 27, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
No offending PR here as the changes are not related to a bug, but to copy / label changes.
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
No regression test needed here as the changes are not related to a bug, but to copy / label changes.
Do we agree 👍 or 👎.
Due to delays in production deploy (internal issue) see PR conversation, we agreed on payment for 15th of July with Beamanator (see comment) given that this issue was simply adding copy / labels and not changing functionality which means the likelyhood for regressions is extremely low.
Shortly after agreeing on 15th, the production deploy was performed, adding the hold for payment 2 days later on 17th.
@slafortune Is this going to be paid out today given the information above ?
changed the title [-][HOLD for payment 2024-07-17] [$250] [Awaiting Payment July 15] Update copy based on accounting integration selections[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [Awaiting Payment July 15] Update copy based on accounting integration selections[/+]on Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 24, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Update copy based on accounting integration selections[/-][+][$250] Update copy based on accounting integration selections[/+]melvin-bot commentedon Jun 27, 2024
Job added to Upwork: https://www.upwork.com/jobs/~010acf66c02b3a1adb
melvin-bot commentedon Jun 27, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)melvin-bot commentedon Jun 27, 2024
Triggered auto assignment to @dannymcclain (
Design), see these Stack Overflow questions for more details.23 remaining items
melvin-bot commentedon Jul 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ikevin127 commentedon Jul 12, 2024
[@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
No offending PR here as the changes are not related to a bug, but to copy / label changes.
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
No regression test needed here as the changes are not related to a bug, but to copy / label changes.
Do we agree 👍 or 👎.
ikevin127 commentedon Jul 15, 2024
Due to delays in production deploy (internal issue) see PR conversation, we agreed on payment for 15th of July with Beamanator (see comment) given that this issue was simply adding copy / labels and not changing functionality which means the likelyhood for regressions is extremely low.
Shortly after agreeing on 15th, the production deploy was performed, adding the hold for payment 2 days later on 17th.
@slafortune Is this going to be paid out today given the information above ?
[-][HOLD for payment 2024-07-17] [$250] [Awaiting Payment July 15] Update copy based on accounting integration selections[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [Awaiting Payment July 15] Update copy based on accounting integration selections[/+]melvin-bot commentedon Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
ikevin127 commentedon Jul 16, 2024
✅ Checklist already completed in #44297 (comment).
I guess we're looking at payments being issued tomorrow (17th of July) ?
cc @slafortune callback to #44297 (comment)
slafortune commentedon Jul 18, 2024
@ikevin127 @gijoe0295 Paid ✅