You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Payment card / Subscription] Correct amounts not showing on "Add payment card" #44417
Depending on whether you have Annual or Pay-per-use and whether you are on Collect or Control we will show this message above the “Add payment card” button:
If an Annual subscription is enabled, which it is by default, we show this for Collect: “From $5/active member with the Expensify Card, $10/active member without the Expensify Card.”
If Pay-per-use is enabled we show this for Collect: “From $10/active member with the Expensify Card, $20/active member without the Expensify Card.”
If an Annual subscription is enabled, which it is by default, we show this for Control: “From $9/active member with the Expensify Card, $18/active member without the Expensify Card.”
If Pay-per-use is enabled we show this for Control: “From $18/active member with the Expensify Card, $36/active member without the Expensify Card.”
Actual Result:
The user is on pay-per-use on Control but the text above "Add payment card" reads "From $5/active member with the Expensify Card, $10/active member without the Expensify Card." when it should read “From $18/active member with the Expensify Card, $36/active member without the Expensify Card.”
Workaround:
Ignore
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Correct amounts not showing on "Add payment card"[/-][+][Payment card / Subscription] Correct amounts not showing on "Add payment card"[/+]on Jun 26, 2024
Activity
melvin-bot commentedon Jun 25, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Jun 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Correct amounts not showing on "Add payment card"
What is the root cause of that problem?
App/src/pages/settings/Subscription/PaymentCard/AddPaymentCard.tsx
Line 83 in e7e9304
The text above is currently hardcoded
What changes do you think we should make in order to solve the problem?
Create a reusable component to display the same text on AddPaymentCard.tsx and SubscriptionPlan.tsx
App/src/pages/settings/Subscription/SubscriptionPlan.tsx
Lines 67 to 71 in e7e9304
What alternative solutions did you explore? (Optional)
App/src/pages/settings/Subscription/PaymentCard/AddPaymentCard.tsx
Line 83 in e7e9304
Replace this code above with the following code
Proof
-1-New-Expensify.mp4
[-]Correct amounts not showing on "Add payment card"[/-][+][Payment card / Subscription] Correct amounts not showing on "Add payment card"[/+]MrMuzyk commentedon Jun 26, 2024
I am Michał from Callstack - expert contributor group. I’d like to work on this job.
trjExpensify commentedon Jun 26, 2024
@MitchExpensify apparently this will be fixed here: https://github.com/Expensify/App/pull/43572/files#diff-d33a8833443831664318c3ec9ea300090935e1aed9ace8b7642ee38a65b026d7R102
MitchExpensify commentedon Jun 27, 2024
Oh nice! Lets be safe and keep this open as a reminder to test once that's on staging
trjExpensify commentedon Jul 1, 2024
#43572 is on staging, so you can retest this.
melvin-bot commentedon Jul 1, 2024
@slafortune, @MrMuzyk Eep! 4 days overdue now. Issues have feelings too...
trjExpensify commentedon Jul 2, 2024
Bump @MitchExpensify for the retest before closing this issue.
melvin-bot commentedon Jul 3, 2024
@slafortune, @MrMuzyk 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
MitchExpensify commentedon Jul 4, 2024
Tested and this is working