Skip to content

[Payment card / Subscription] Correct amounts not showing on "Add payment card" #44417

Closed

Description

@MitchExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.2-0
Reproducible in staging?: Staging
Reproducible in production?: No - You must navigate to https://staging.new.expensify.com/settings/subscription
If this was caught during regression testing, add the test name, ID and link from TestRail: NA
Email or phone of affected tester (no customers): wardmi@tcd.ie
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: NA
Issue reported by: mitch@expensify.com
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1719350462833819

Action Performed:

As a workspace owner with Pay-per-use and/or a Control plan that also has no payment card saved;

  1. Go to https://staging.new.expensify.com/settings/subscription
  2. Click "Add payment card"

Expected Result:

Depending on whether you have Annual or Pay-per-use and whether you are on Collect or Control we will show this message above the “Add payment card” button:

  • If an Annual subscription is enabled, which it is by default, we show this for Collect: “From $5/active member with the Expensify Card, $10/active member without the Expensify Card.”
  • If Pay-per-use is enabled we show this for Collect: “From $10/active member with the Expensify Card, $20/active member without the Expensify Card.”
  • If an Annual subscription is enabled, which it is by default, we show this for Control: “From $9/active member with the Expensify Card, $18/active member without the Expensify Card.”
  • If Pay-per-use is enabled we show this for Control: “From $18/active member with the Expensify Card, $36/active member without the Expensify Card.”

Actual Result:

The user is on pay-per-use on Control but the text above "Add payment card" reads "From $5/active member with the Expensify Card, $10/active member without the Expensify Card." when it should read “From $18/active member with the Expensify Card, $36/active member without the Expensify Card.”

Workaround:

Ignore

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

image

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 25, 2024
  2. melvin-bot commented on Jun 25, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nyomanjyotisa commented on Jun 26, 2024

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Correct amounts not showing on "Add payment card"

    What is the root cause of that problem?

    From $5/active member with the Expensify Card, $10/active member without the Expensify Card.

    The text above is currently hardcoded

    What changes do you think we should make in order to solve the problem?

    Create a reusable component to display the same text on AddPaymentCard.tsx and SubscriptionPlan.tsx

    <Text style={[styles.textLabelSupporting, styles.mb2]}>
    {translate(`subscription.yourPlan.${isCollect ? 'collect' : 'control'}.${isAnnual ? 'priceAnnual' : 'pricePayPerUse'}`, {
    lower: convertToShortDisplayString(subscriptionPrice, preferredCurrency),
    upper: convertToShortDisplayString(subscriptionPrice * CONST.SUBSCRIPTION_PRICE_FACTOR, preferredCurrency),
    })}

    What alternative solutions did you explore? (Optional)

    From $5/active member with the Expensify Card, $10/active member without the Expensify Card.

    Replace this code above with the following code

    {translate(`subscription.yourPlan.${isCollect ? 'collect' : 'control'}.${isAnnual ? 'priceAnnual' : 'pricePayPerUse'}`, {
       lower: convertToShortDisplayString(subscriptionPrice, preferredCurrency),
       upper: convertToShortDisplayString(subscriptionPrice * CONST.SUBSCRIPTION_PRICE_FACTOR, preferredCurrency),
    })}
    

    Proof

    -1-New-Expensify.mp4
  4. changed the title [-]Correct amounts not showing on "Add payment card"[/-] [+][Payment card / Subscription] Correct amounts not showing on "Add payment card"[/+] on Jun 26, 2024
  5. MrMuzyk commented on Jun 26, 2024

    @MrMuzyk
    Contributor

    I am Michał from Callstack - expert contributor group. I’d like to work on this job.

  6. trjExpensify commented on Jun 26, 2024

    @trjExpensify
    Contributor
  7. MitchExpensify commented on Jun 27, 2024

    @MitchExpensify
    ContributorAuthor

    Oh nice! Lets be safe and keep this open as a reminder to test once that's on staging

  8. trjExpensify commented on Jul 1, 2024

    @trjExpensify
    Contributor

    #43572 is on staging, so you can retest this.

  9. melvin-bot commented on Jul 1, 2024

    @melvin-bot

    @slafortune, @MrMuzyk Eep! 4 days overdue now. Issues have feelings too...

  10. trjExpensify commented on Jul 2, 2024

    @trjExpensify
    Contributor

    Bump @MitchExpensify for the retest before closing this issue.

  11. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    @slafortune, @MrMuzyk 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  12. MitchExpensify commented on Jul 4, 2024

    @MitchExpensify
    ContributorAuthor

    Tested and this is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions