[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [UX Reliability] [Navigation] Going back from the about page seems to be pushing the settings

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719398711127039

Action Performed:

Launch the app
Tap Settings
Tap About
Tap Back arrow

Expected Result:

The about page animated from left to right and settings page displayed

Actual Result:

Settings page animated in from right

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

RPReplay_Final1719396418.MP4

RPReplay_Final1719413675.MP4

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dukenv0307

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Going back from about page push a new bottom navigator. This happens with troubleshoot page too.

What is the root cause of that problem?

In both about and troubleshoot pages, we call goBack with the settings page as the fallback route.

App/src/pages/settings/AboutPage/AboutPage.tsx

Line 138 in 9d8e7fe

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

App/src/pages/settings/Troubleshoot/TroubleshootPage.tsx

Line 95 in 9d8e7fe

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

Both pages are central pane, so it will check if there is an about or troubleshoot page in the stack, if not found, then we replace the current page with the fallback route, in this case the settings page.

App/src/libs/Navigation/Navigation.ts

Lines 237 to 241 in 9d8e7fe

    
           // Allow CentralPane to use UP with fallback route if the path is not found in root navigator. 
        
           if (isCentralPaneFocused && fallbackRoute && distanceFromPathInRootNavigator === -1) { 
        
               navigate(fallbackRoute, CONST.NAVIGATION.TYPE.UP); 
        
               return; 
        
           }

Troubleshoot page doesn't have the fallback before but was added in #39230.

What changes do you think we should make in order to solve the problem?

We don't need fallback route for both pages, so remove the fallback route from both about and troubleshoot pages.

This is similar to #36050.

@bernhardoj

@bernhardoj There are also issues with switching the bottom tabs as you can see around 15 second in the first video. The bug report did not mention it well. Do you know what is causing that?

Do you mean this one?

a.mp4

It won't happen anymore once we remove the fallback route. It happens because when going back from troubleshoot page, we push another bottom navigator to the stack. Navigating to another bottom tab screen will pop the extra bottom tab.

Hi! I'm working on that!

@WojtekBoman

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix navigating back from Settings screens and refreshing SearchPage with policyIDs in the url #44622

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

@WojtekBoman does not require payment (Contractor)
@dukenv0307 requires payment (Needs manual offer from BZ)

@dukenv0307

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@dukenv0307] Determine if we should create a regression test for this bug.
[@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@dukenv0307

@dukenv0307 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01697f8ed31a8b4999

Can you also complete the BZ checklist above? Thx

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test:

First issue

Select any workspace on SearchPage
Refresh the page
Verify if the workspace switcher icon matches the selected workspace.

Second issue

Launch the app
Tap Settings
Tap About
Tap Back arrow
Verify if navigating back to the Settings works properly and the animation is correct (The about page animated from left to right)

@dukenv0307

@dukenv0307 please accept the Upwork job.
Please also provide reasoning for testr cases not needing to be created. If it's cuz it's design/edge case, we still want a test case cuz QA can run it every month.

I updated the test case

@dukenv0307

@dukenv0307 please accept the Upwork job.

@mallenexpensify Done, thank you!

@dukenv0307

Contributor+: @dukenv0307 paid $250 via Upwork.

TR GH

https://github.com/Expensify/Expensify/issues/414089

Thanks!

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [UX Reliability] [Navigation] Going back from the about page seems to be pushing the settings #44478

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

12 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Allow CentralPane to use UP with fallback route if the path is not found in root navigator.
	if (isCentralPaneFocused && fallbackRoute && distanceFromPathInRootNavigator === -1) {
	navigate(fallbackRoute, CONST.NAVIGATION.TYPE.UP);
	return;
	}

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [UX Reliability] [Navigation] Going back from the about page seems to be pushing the settings #44478

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 26, 2024

bernhardoj commented on Jun 27, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

mountiny commented on Jun 27, 2024

bernhardoj commented on Jun 28, 2024

WojtekBoman commented on Jun 28, 2024

12 remaining items

melvin-bot commented on Jul 15, 2024

melvin-bot commented on Jul 15, 2024

mallenexpensify commented on Jul 18, 2024

dukenv0307 commented on Jul 18, 2024

mallenexpensify commented on Jul 19, 2024

dukenv0307 commented on Jul 19, 2024

dukenv0307 commented on Jul 19, 2024

mallenexpensify commented on Jul 20, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions