You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense #44490
changed the title [-]Extra margin below the header and above the expense information when viewing an expense[/-][+][HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense[/+]on Jul 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[] The PR that introduced the bug has been identified. Link to the PR:
[] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[] Determine if we should create a regression test for this bug.
[] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense[/+]on Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[] The PR that introduced the bug has been identified. Link to the PR:
[] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[] Determine if we should create a regression test for this bug.
[] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jun 26, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.etCoderDysto commentedon Jun 26, 2024
Same root cause with #44434
shawnborton commentedon Jun 26, 2024
Interesting, the video that @m-natarajan posted doesn't actually have the bug. Maybe we need more clear reproduction steps here...
shawnborton commentedon Jun 26, 2024
Ah yes @etCoderDysto - thanks for linking that, that does look like the issue.
etCoderDysto commentedon Jun 26, 2024
No problem 🙌
melvin-bot commentedon Jul 1, 2024
@anmurali Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Jul 3, 2024
@anmurali Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Jul 5, 2024
@anmurali 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
anmurali commentedon Jul 8, 2024
Closing this as a dupe of #44434
[-]Extra margin below the header and above the expense information when viewing an expense[/-][+][HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense[/+]melvin-bot commentedon Jul 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-17. 🎊
melvin-bot commentedon Jul 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense[/+]melvin-bot commentedon Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: