Repository navigation
App crashes when attempting to open an #admins room #44583
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.3-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @francoisl
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719528213578329
Action Performed:
- Create a workspace
- Open the workspace's settings page and change anything that would cause a system message in the admins room
For example, create, delete, rename or disable a category ; add tags, etc. - Try to open the admins room for that workspace
Expected Result:
Workspace Admin room opens
Actual Result:
App crashes when opening admin room
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Jun 28, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jun 28, 2024
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 28, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
neonbhai commentedon Jun 28, 2024
Fixed on latest main:
Screen.20Recording.202024-06-28.20at.205.mp4
robertjchen commentedon Jun 28, 2024
got it, thanks!
23 remaining items
jasperhuangg commentedon Jul 1, 2024
Looks like @roryabraham is OOO today so in the interest of pushing deploy forward I'm gonna go ahead and revert that PR
jasperhuangg commentedon Jul 1, 2024
btw @roryabraham here's the error
roryabraham commentedon Jul 1, 2024
Reverting that PR will cause another regression @jasperhuangg
edit: sorry, was thinking of another PR. This one should be fine to revert
roryabraham commentedon Jul 1, 2024
@jasperhuangg can you try this PR and see if it solves the problem?
#44681
roryabraham commentedon Jul 1, 2024
If it does, you could actually take it a step further and just remove the
useLastAccessedReportIDhook and putfindLastAccessedReportin auseEffectdirectlyneonbhai commentedon Jul 1, 2024
Came across very similar warning to #44583 (comment) while investigating this on native device, asking to memoize getSnapshot call in useOnyx.ts
Image
jasperhuangg commentedon Jul 1, 2024
Ah shoot @roryabraham jumped the gun and missed your messages, my bad! The CP is already under way and it looks like that PR you linked is still an early draft–do you mind if we try to get it out in tomorrow's deploy? I'd feel better if we had some more time to test everything thoroughly without any time pressure today.
jasperhuangg commentedon Jul 2, 2024
Can't reproduce this anymore on staging