[HOLD for payment 2024-07-24] Pay someone - System message thread does not show up on LHN

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0-3.1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #43742

Action Performed:

Go to staging.new.expensify.com
Go to any chat
Go to + > Pay someone
Enter amount and pay them
Go to transaction thread
Right click on paid system message > Reply in thread
Send a reply

Expected Result:

System message thread will show up on LHN

Actual Result:

System message thread is missing on LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6526860_1719530886499.pay_some.mp4

View all open jobs on GitHub

@hayata-suenaga

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@hayata-suenaga

@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

System message thread is missing on LHN

What is the root cause of that problem?

When we pay someone, the paid system message is the send money action and the child of this action is transaction thread report.

If the report is the one transaction thread we don't show it in LHN here) but we still can access to this report . This bug also happens if we access to the transaction thread report of the combine report.

What changes do you think we should make in order to solve the problem?

I don't think it makes sense to hide the transaction thread report in LHN if it's the one transaction thread because we still can access this report via deeplink or go back from the child thread of this report. I think we can remove this check.

App/src/libs/ReportUtils.ts

Lines 5434 to 5436 in 1d607ac

    
           if (isOneTransactionThread(report.reportID, report.parentReportID ?? '-1')) { 
        
               return false; 
        
           }

What alternative solutions did you explore? (Optional)

Display not found page if it doesn't show in LHN.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The paid system message thread doesn't show in LHN.

What is the root cause of that problem?

The paid system message thread is a one-transaction thread and we don't show a one-transaction thread in LHN.

App/src/libs/ReportUtils.ts

Lines 5433 to 5436 in 1d607ac

    
           // If this is a transaction thread associated with a report that only has one transaction, omit it 
        
           if (isOneTransactionThread(report.reportID, report.parentReportID ?? '-1')) { 
        
               return false; 
        
           }

This issue is reproducible after #43742. Previously, the paid system message was combined into the one-transaction report so it's not possible for the user to open the paid system message thread manually, but now we show it so the users know the paid method.

What changes do you think we should make in order to solve the problem?

Because we make an exception to the combined report actions for the paid system message, we should do the same for shouldReportBeInOptionList by ignoring it if it's a paid action.

if (isOneTransactionThread(report.reportID, report.parentReportID ?? '-1') && !ReportActionsUtils.isSentMoneyReportAction(parentReportAction)) {
    return false;
}

@bernhardoj

@bernhardoj's solution seems to address the cause. Assining @bernhardoj. @bernhardoj, is it possible to open a PR as soon as possible?

@bernhardoj

$250 approved for @bernhardoj

The PR that introduced the bug has been identified. Link to the PR: fix: display thread of send money request as normal thread #43742
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: display thread of send money request as normal thread #43742 (comment)

Regression Test Proposal

Go to staging.new.expensify.com
Go to any chat
Go to + > Pay someone
Enter an amount and pay them
Go to transaction thread
Right click on paid system message > Reply in thread
Send a reply
Verify that system message thread is shown in LHN

@eVoloshchak

$250 approved for @eVoloshchak. Re-opening for regression test.

Will handle in the morning

@muttmuure

@muttmuure, @bernhardoj Huh... This is 4 days overdue. Who can take care of this?

@muttmuure

@muttmuure, @bernhardoj Still overdue 6 days?! Let's take care of this!

Regression test created

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-24] Pay someone - System message thread does not show up on LHN #44586

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

29 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isOneTransactionThread(report.reportID, report.parentReportID ?? '-1')) {
	return false;
	}

	// If this is a transaction thread associated with a report that only has one transaction, omit it
	if (isOneTransactionThread(report.reportID, report.parentReportID ?? '-1')) {
	return false;
	}

[HOLD for payment 2024-07-24] Pay someone - System message thread does not show up on LHN #44586

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 28, 2024

github-actions commented on Jun 28, 2024

lanitochka17 commented on Jun 28, 2024

dominictb commented on Jun 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

bernhardoj commented on Jun 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

hayata-suenaga commented on Jun 28, 2024

29 remaining items

JmillsExpensify commented on Jul 30, 2024

eVoloshchak commented on Aug 5, 2024

JmillsExpensify commented on Aug 5, 2024

muttmuure commented on Aug 7, 2024

melvin-bot commented on Aug 13, 2024

melvin-bot commented on Aug 15, 2024

muttmuure commented on Aug 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions