Skip to content

[HOLD for payment 2024-07-30] [$250] [Search v1] Settings - Delay in avatar highlight and blank Search page when opening from Inbox #44587

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com/settings/preferences/priority-mode
  2. Click Account settings
  3. Go to Inbox
  4. Go to Search

Expected Result:

In Step 2, avatar will be instantly highlighted when clicking on Account settings
In Step 4, Search page will open instantly

Actual Result:

In Step 2, avatar is not instantly highlighted when clicking on Account settings
In Step 4, Search page opens with blank page for a few seconds

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6526861_1719530887474.20240628_070751.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011ff0642a6c2f2946
  • Upwork Job ID: 1806537464995654813
  • Last Price Increase: 2024-06-28
  • Automatic offers:
    • ikevin127 | Reviewer | 102989312
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 28, 2024
  2. melvin-bot commented on Jun 28, 2024

    @melvin-bot

    Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jun 28, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jun 28, 2024

    @lanitochka17
    Author

    @robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jun 28, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 28, 2024
  7. melvin-bot commented on Jun 28, 2024

    @melvin-bot
  8. 60 remaining items

  9. lschurr commented on Jul 24, 2024

    @lschurr
    Contributor

    @Zakpak0 - can you link your Upwork profile here so that I can send along the offer?

  10. lschurr commented on Jul 24, 2024

    @lschurr
    Contributor

    Payment summary:

  11. Zakpak0 commented on Jul 24, 2024

    @Zakpak0
    Contributor

    @Zakpak0 - can you link your Upwork profile here so that I can send along the offer?

    @lschurr sure https://www.upwork.com/freelancers/~0144a75be415af6251

  12. ikevin127 commented on Jul 25, 2024

    @ikevin127
    Contributor

    @lschurr 👋 Before closing here, there's one more payment due on 30th coming from a follow-up polishing PR #45663 which I reviewed. More context on the payment due date here and confirmation that it should be handled in this issue from Carlos in #45663 (comment).

    ⚠️ Looks like automation failed -> reason for which the 2nd payment due date wasn't added to this issue automatically.

  13. lschurr commented on Jul 26, 2024

    @lschurr
    Contributor
  14. lschurr commented on Jul 26, 2024

    @lschurr
    Contributor

    I'll change the date in the title for the other payment that's due on the 30th. That PR was created by @WojtekBoman and reviewed by @ikevin127 - so we just need payment for you, right Kevin?

  15. ikevin127 commented on Jul 26, 2024

    @ikevin127
    Contributor

    @lschurr Yes, only for me as reviewer since the author is from SWM. Thank you!

  16. changed the title [-][HOLD for payment 2024-07-24] [$250] [Search v1] Settings - Delay in avatar highlight and blank Search page when opening from Inbox[/-] [+][HOLD for payment 2024-07-30] [$250] [Search v1] Settings - Delay in avatar highlight and blank Search page when opening from Inbox[/+] on Jul 26, 2024
  17. added and removed on Jul 26, 2024
  18. ikevin127 commented on Jul 30, 2024

    @ikevin127
    Contributor
  19. lschurr commented on Jul 30, 2024

    @lschurr
    Contributor

    @ikevin127 - I added a bonus rather than sending a new offer on this one.

    Additional $250 paid in Upwork for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions