Skip to content

[HOLD for payment 2024-07-25] [$250] Pay someone - Paid system message is not highlighted when clicking on the message link #44588

New issue
New issue
Closed
Closed
[HOLD for payment 2024-07-25] [$250] Pay someone - Paid system message is not highlighted when clicking on the message link#44588
Assignees
twisterdotcomhungvu193marcaaronbernhardoj
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Jun 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0-3.1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #43742

Action Performed:

  1. Go to staging.new.expensify.com/
  2. Go to FAB > Pay someone
  3. Enter amount, select a user and pay them
  4. Go to transaction thrad
  5. Right click on the paid system message > Copy link
  6. Paste the link in the transaction thread
  7. Tap on the link

Expected Result:

The paid system message will be highlighted

Actual Result:

The paid system message is highlighted only briefly. The report loads briefly with skeleton and the message is no longer highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6526869_1719532851665.20240628_075834.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0166f7822923f5e0f7
  • Upwork Job ID: 1806505240961845071
  • Last Price Increase: 2024-06-28
  • Automatic offers:
    • hungvu193 | Reviewer | 102950113
    • bernhardoj | Contributor | 102950114
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. lanitochka17
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 28, 2024

  2. melvin-bot commented on Jun 28, 2024

    @melvin-bot
    melvin-botBot
    on Jun 28, 2024 – with Melvin Bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot
    assigned
    twisterdotcom
    on Jun 28, 2024
  4. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    and removed
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 28, 2024

  5. melvin-bot commented on Jun 28, 2024

    @melvin-bot
    melvin-botBot
    on Jun 28, 2024 – with Melvin Bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. melvin-bot
    assigned
    marcaaron
    on Jun 28, 2024
  7. github-actions
    added
    Engineering
    HourlyKSv2
    on Jun 28, 2024

  8. github-actions commented on Jun 28, 2024

    @github-actions
    github-actionsBot
    on Jun 28, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. lanitochka17 commented on Jun 28, 2024

    @lanitochka17
    lanitochka17
    on Jun 28, 2024
    Author

    @marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  10. marcaaron
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 28, 2024

  11. 44 remaining items

  12. melvin-bot
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jul 18, 2024
  13. melvin-bot
    changed the title [-][$250] Pay someone - Paid system message is not highlighted when clicking on the message link[/-] [+][HOLD for payment 2024-07-25] [$250] Pay someone - Paid system message is not highlighted when clicking on the message link[/+] on Jul 18, 2024

  14. melvin-bot commented on Jul 18, 2024

    @melvin-bot
    melvin-botBot
    on Jul 18, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot
    removed
    ReviewingHas a PR in review
    on Jul 18, 2024

  16. melvin-bot commented on Jul 18, 2024

    @melvin-bot
    melvin-botBot
    on Jul 18, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-25. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Jul 18, 2024

    @melvin-bot
    melvin-botBot
    on Jul 18, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
    • [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hungvu193] Determine if we should create a regression test for this bug.
    • [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  18. bernhardoj commented on Jul 18, 2024

    @bernhardoj
    bernhardoj
    on Jul 18, 2024
    Contributor

    I'll request in ND once payment is due.

  19. hungvu193 commented on Jul 24, 2024

    @hungvu193
    hungvu193
    on Jul 24, 2024
    Contributor

    Regression Test:

    1. Go to any report and submit an expense.
    2. Enter amount, select a user and pay them.
    3. Click on that expense to open the thread.
    4. Right click on the paid system message > Copy link.
    5. Paste the link in the transaction thread.
    6. Click on that link.
    7. Verify that the paid system message is highlighted.

    Do we 👍 or 👎 ?

  20. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jul 24, 2024

  21. marcaaron commented on Jul 24, 2024

    @marcaaron
    marcaaron
    on Jul 24, 2024
    Contributor

    LGTM

  22. twisterdotcom commented on Jul 24, 2024

    @twisterdotcom
    twisterdotcom
    on Jul 24, 2024
    Contributor

    Payment Summary:

  23. twisterdotcom
    closed this as completedon Jul 24, 2024

  24. bernhardoj commented on Jul 25, 2024

    @bernhardoj
    bernhardoj
    on Jul 25, 2024
    Contributor

    Requested in ND.

  25. JmillsExpensify commented on Jul 26, 2024

    @JmillsExpensify
    JmillsExpensify
    on Jul 26, 2024
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions