[$250] Attachment – Cursor moves to beginning of password in PDF protected file when click on eye

@allgandalf

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4678543
Email or phone of affected tester (no customers): applausetester+jp_e_category_1@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Go to https://staging.new.expensify.com/
Log in
Open any chat
Click on + and Add attachment
Select PDF protected file (do not click send)
Click on Enter the password
Enter text and click on the Eye to make your text visible

Expected Result:

Cursor is at the end of the password in PDF protected file when click on the eye

Actual Result:

Cursor moves to the beginning of the password in PDF protected file when click on the eye

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6526992_1719551334358.Atach.mp4

PDf file
Password_protected_Test12345.pdf

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01eb95943a6e16733e
Upwork Job ID: 1806640970628869277
Last Price Increase: 2024-06-28

Issue Owner

Current Issue Owner: @allgandalf

@joekaufmanexpensify

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@nkuoch

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@joekaufmanexpensify

@joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #vip-vsb.

Definitely not a blocker. I'm not sure we should even bothering to fix this to be honest.

Job added to Upwork: https://www.upwork.com/jobs/~01eb95943a6e16733e

@allgandalf

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

When clicking on the eye icon in a PDF protected file, the cursor moves to the beginning of the password field.

What is the root cause of that problem?

The root cause is passwordHidden state change that triggers secureTextEntry prop change.

What changes do you think we should make in order to solve the problem?

We need to remember the cursor position in the BaseTextInput component and use setSelectionRange to restore it when togglePasswordVisibility is called. Instead of tracking it with a new useEffect, we can use requestAnimationFrame or setTimeout as alternative to ensure the DOM has updated before restoring the cursor position in togglePasswordVisibility.

@Julesssss

Agreed with @Julesssss. The #vip-vsb project has been paused, so this doesn't feel worth prioritizing right now. This is a very niche bug. I'd be surprised if many/any customers experience this, and even if they do, there isn't really much impact.

Going to close this for now, and we can revisit when/if we ever receive feedback from customers about this.

Navigation Menu

Repository navigation

[$250] Attachment – Cursor moves to beginning of password in PDF protected file when click on eye #44599

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

2 remaining items

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$250] Attachment – Cursor moves to beginning of password in PDF protected file when click on eye #44599

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 28, 2024

melvin-bot commented on Jun 28, 2024

github-actions commented on Jun 28, 2024

izarutskaya commented on Jun 28, 2024

izarutskaya commented on Jun 28, 2024

2 remaining items

Julesssss commented on Jun 28, 2024

melvin-bot commented on Jun 28, 2024

melvin-bot commented on Jun 28, 2024

grogou commented on Jun 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

joekaufmanexpensify commented on Jun 28, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions