Skip to content

Workspace - Skeleton loader not displayed in workspace member page #44604

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #43893
Email or phone of affected tester (no customers): dave0123seife+stest@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open app.
  2. Go to Account settings > workspace > member page
    Notice that Skeleton loader is not displayed in workspace member page when data is loading

Expected Result:

Skeleton loader is displayed in workspace member page when data is loading

Actual Result:

Skeleton loader is not displayed in workspace member page when data is loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6526935_1719542907215.video_2024-06-28_05-47-04.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 28, 2024
  2. melvin-bot commented on Jun 28, 2024

    @melvin-bot

    Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 28, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jun 28, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jun 28, 2024

    @izarutskaya
    Author

    @jliexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Jun 28, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. izarutskaya commented on Jun 28, 2024

    @izarutskaya
    Author

    Difference between stg and prod

    Recording.2587.mp4
  8. 2 remaining items

  9. MariaHCD commented on Jun 28, 2024

    @MariaHCD
    Contributor

    @izarutskaya did we test the PR prematurely? 🤔

  10. Pujan92 commented on Jun 28, 2024

    @Pujan92
    Contributor

    It seems to be an automation issue bcoz the changes of that PR are reflected in the staging branch code.

    Screenshot 2024-06-28 at 19 09 31
  11. jjcoffee commented on Jun 28, 2024

    @jjcoffee
    Contributor

    Hmm so from my testing there is no issue on staging. The loader shows when the connection speed is throttled enough for it to show, exactly the same as on production. @izarutskaya Do you mind retesting with a throttled connection?

  12. blimpich commented on Jun 28, 2024

    @blimpich
    Contributor

    asked for retest here

  13. blimpich commented on Jun 28, 2024

    @blimpich
    Contributor

    Also I don't think this should block the deploy.

  14. removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 28, 2024
  15. jliexpensify commented on Jul 1, 2024

    @jliexpensify
    Contributor

    Hi, just moving to a Daily (I assume that's ok?)

  16. kbecciv commented on Jul 1, 2024

    @kbecciv

    Issue is not reproduced on a slow network

    Workspace.skeleton.mp4
  17. blimpich commented on Jul 1, 2024

    @blimpich
    Contributor

    Great lets close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions