[$250] Expense - Preview in main chat briefly disappears after renaming report and deleting expense

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0-3.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4678766
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Go to staging.new.expensify.com/
Go to workspace chat.
Submit two expenses.
Go to expense report.
Click Title field.
Change the report title and save it.
Submit another expense.
Go to main chat and back to expense report for the rename message to show up.
Go to transaction thread of the latest expense (submitted in Step 7).
Click on the report header > Delete expense.
Delete the expense.

Expected Result:

App will return to expense report because there are still two expenses in the report.

Actual Result:

App returns to main chat, and the expense preview in the main chat disappears briefly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6527060_1719557112849.20240628_143744.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d610c7726bd86731
Upwork Job ID: 1807883887257636893
Last Price Increase: 2024-07-08

@johncschuster

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think this issue might be related to the #collect project.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleting a transaction removes the expense report if the last action in the expense report is renamed action.

What is the root cause of that problem?

The expense report will be deleted if the last message text of the expense report is empty.

App/src/libs/actions/IOU.ts

Lines 5313 to 5315 in cb8fce8

    
           const iouReportLastMessageText = ReportActionsUtils.getLastVisibleMessage(iouReport?.reportID ?? '-1', updatedReportAction).lastMessageText; 
        
           const shouldDeleteIOUReport = 
        
               iouReportLastMessageText.length === 0 && !ReportActionsUtils.isDeletedParentAction(lastVisibleAction) && (!transactionThreadID || shouldDeleteTransactionThread);

We get the last message from the HTML of the message here (getTextFromHtml).

App/src/libs/ReportActionsUtils.ts

Lines 765 to 771 in cb8fce8

    
           let messageText = getTextFromHtml(message?.html) ?? ''; 
        
           if (messageText) { 
        
               messageText = StringUtils.lineBreaksToSpaces(String(messageText)).substring(0, CONST.REPORT.LAST_MESSAGE_TEXT_MAX_LENGTH).trim(); 
        
           } 
        
           return { 
        
               lastMessageText: messageText, 
        
           };

However, the renamed action doesn't have HTML.

What changes do you think we should make in order to solve the problem?

Instead of using getTextFromHtml, we can use getReportActionMessageText.

let messageText = getReportActionMessageText(lastVisibleAction) ?? '';

getReportActionMessageText will get from the HTML but fallback to text if it doesn't exist.

App/src/libs/ReportActionsUtils.ts

Lines 1353 to 1360 in 53d08c1

    
           function getReportActionMessageText(reportAction: OnyxEntry<ReportAction>): string { 
        
               if (!Array.isArray(reportAction?.message)) { 
        
                   return getReportActionText(reportAction); 
        
               } 
        
               // Sometime html can be an empty string 
        
               // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing 
        
               return reportAction?.message?.reduce((acc, curr) => `${acc}${getTextFromHtml(curr?.html || curr?.text)}`, '') ?? ''; 
        
           }

So the iou report last message won't be empty and the expense report won't be deleted.

@johncschuster

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

Job added to Upwork: https://www.upwork.com/jobs/~01d610c7726bd86731

@sobitneupane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@tylerkaraszewski

This issue has not been updated in over 15 days. @tylerkaraszewski, @johncschuster, @sobitneupane, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@johncschuster

@johncschuster This is ready for payment. PR was developed a month back. #45365 (comment)

@johncschuster

Bump @johncschuster

Payment pending. Requested in ND.

Sorry for the delay! Working on this now.

@bernhardoj

Payment Summary:

Contributor: @bernhardoj owed $250 via NewDot
Contributor+: @sobitneupane owed $250 via NewDot

@bernhardoj

$250 approved for @bernhardoj

@sobitneupane

@sobitneupane, do we need any regression test steps? If so, can you provide them?

Regression Test Proposal

Open a workspace chat
Submit 2 money requests
Rename the expense report title
Reopen/refresh the expense report to see the renamed system message
Add another money request
Delete the recently added money request
Verify the expense report isn't deleted and you stay at the expense report page

Do we agree 👍 or 👎

@sobitneupane

Thanks, @sobitneupane! Please request payment!

@sobitneupane

$250 approved for @sobitneupane

Navigation Menu

Repository navigation

[$250] Expense - Preview in main chat briefly disappears after renaming report and deleting expense #44607

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const iouReportLastMessageText = ReportActionsUtils.getLastVisibleMessage(iouReport?.reportID ?? '-1', updatedReportAction).lastMessageText;
	const shouldDeleteIOUReport =
	iouReportLastMessageText.length === 0 && !ReportActionsUtils.isDeletedParentAction(lastVisibleAction) && (!transactionThreadID \|\| shouldDeleteTransactionThread);

	let messageText = getTextFromHtml(message?.html) ?? '';
	if (messageText) {
	messageText = StringUtils.lineBreaksToSpaces(String(messageText)).substring(0, CONST.REPORT.LAST_MESSAGE_TEXT_MAX_LENGTH).trim();
	}
	return {
	lastMessageText: messageText,
	};

	function getReportActionMessageText(reportAction: OnyxEntry<ReportAction>): string {
	if (!Array.isArray(reportAction?.message)) {
	return getReportActionText(reportAction);
	}
	// Sometime html can be an empty string
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	return reportAction?.message?.reduce((acc, curr) => `${acc}${getTextFromHtml(curr?.html \|\| curr?.text)}`, '') ?? '';
	}

[$250] Expense - Preview in main chat briefly disappears after renaming report and deleting expense #44607

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 28, 2024

izarutskaya commented on Jun 28, 2024

bernhardoj commented on Jun 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Jul 1, 2024

melvin-bot commented on Jul 1, 2024

melvin-bot commented on Jul 1, 2024

22 remaining items

melvin-bot commented on Aug 21, 2024

sobitneupane commented on Aug 22, 2024

sobitneupane commented on Sep 2, 2024

bernhardoj commented on Sep 4, 2024

johncschuster commented on Sep 9, 2024

johncschuster commented on Sep 9, 2024

JmillsExpensify commented on Sep 9, 2024

johncschuster commented on Sep 10, 2024

sobitneupane commented on Sep 12, 2024

johncschuster commented on Sep 20, 2024

garrettmknight commented on Oct 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions