[HOLD for payment 2024-07-24] [$250] Split tax - Tax amount is negative when manually entering tax amount when splitting expense

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0-3.2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4678911
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Taxes feature is enabled.
Workspace has at least one non-zero tax rate

Go to staging.new.expensify.com
Go to workspace chat
Go to + > Split expense > Manual
Enter amount > Next
Click Show more > Tax rate
Select a non-zero tax rate
Click Tax amount
Manually enter the tax amount
Split the expense
Click on the split preview

Expected Result:

The tax amount will not be negative

Actual Result:

The tax amount is negative when manually entering tax amount when splitting expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6527444_1719582486649.20240628_214259.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f472383a767ded73
Upwork Job ID: 1808173052119824825
Last Price Increase: 2024-07-02

Issue Owner

Current Issue Owner: @mallenexpensify

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@CortneyOfstad

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

BE returns negative tax amount when editing tax amount manually. And we convert the negative tax amount to formatted tax amount here in MoneyRequestConfimationListFooter without first converting the tax amount into positive value as we do in MoneyRequestView.

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 254 in 937c418

    
           const formattedTaxAmount = CurrencyUtils.convertToDisplayString(transaction?.taxAmount, iouCurrencyCode);

And display the formatted value here

App/src/components/MoneyRequestConfirmationListFooter.tsx

Lines 484 to 487 in 937c418

    
           <MenuItemWithTopDescription 
        
               key={`${taxRates?.name}${formattedTaxAmount}`} 
        
               shouldShowRightIcon={canModifyTaxFields} 
        
               title={formattedTaxAmount}

What changes do you think we should make in order to solve the problem?

As we do in MoneyRequestView, we should first convert the taxAmount to positive following the same method used in Money RequestVeiw

const taxAmount = TransactionUtils.getTaxAmount(transaction, false);

getTaxAmount() returns the absolute value of transaction.taxAmount

Then we format it

const formattedTaxAmount = CurrencyUtils.convertToDisplayString(taxAmount, iouCurrencyCode);

here

https://github.com/Expensify/App/blob/937c4186409725b57fdaae6ae8e1d8c85a9d52a0/src/components/MoneyRequestConfirmationListFooter.tsx#L254C11-L254C29

Note: Instead of passing false as isExpenseReport param to 'getTaxAmount', we can calculate isExpenseReport using TransactionUtils.isExpenseReport(report)).

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tax amount is negative when manually entering tax amount when splitting expense

What is the root cause of that problem?

If we create a split bill with entering the tax amount manually, BE returns the tax amount as negative amount for expense report.

And in here, we doesn't convert the tax mount to positive value before getting the formatted string.

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 254 in 5cebd3e

    
           const formattedTaxAmount = CurrencyUtils.convertToDisplayString(transaction?.taxAmount, iouCurrencyCode);

What changes do you think we should make in order to solve the problem?

If we create a split bill with entering the tax amount manually, BE returns the tax amount as negative amount for expense report.

With this case BE returns the tax amount as negative amount for expense report. But if we don't enter the tax amount manually, BE returns it as positive amount. So here we should use getTaxAmountAbsValue to make sure that the displayed tax amount is always positive value

const formattedTaxAmount = CurrencyUtils.convertToDisplayString(ModifiedExpenseMessage.getTaxAmountAbsValue(transaction?.taxAmount ?? 0), iouCurrencyCode);

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 254 in 5cebd3e

    
           const formattedTaxAmount = CurrencyUtils.convertToDisplayString(transaction?.taxAmount, iouCurrencyCode);

What alternative solutions did you explore? (Optional)

We can fix from BE side to always return the tax amount of split bill transaction in expense report as negative amount
And then here, we can use getTaxAmount function that had already covered the negative amount case for expense chat.

const formattedTaxAmount = CurrencyUtils.convertToDisplayString(TransactionUtils.getTaxAmount(transaction, isPolicyExpenseChat), iouCurrencyCode);

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 254 in 5cebd3e

    
           const formattedTaxAmount = CurrencyUtils.convertToDisplayString(transaction?.taxAmount, iouCurrencyCode);

@CortneyOfstad

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

I was able to recreate so going to get eyes on this!

Job added to Upwork: https://www.upwork.com/jobs/~01f472383a767ded73

@aimane-chnaif

Payment Summary

Upwork Job

Reviewer: @aimane-chnaif owed $250 via NewDot
ROLE: @etCoderDysto paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@CortneyOfstad)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1808173052119824825/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@aimane-chnaif

@aimane-chnaif — please complete the check ASAP so there is no further delay in payment. Thanks!

@etCoderDysto — I sent you an offer in Upwork, please let me know once you accept and I will get that paid ASAP. Thanks!

@CortneyOfstad

@CortneyOfstad I have accepted the offer.
Thank you!

Offending PR with comment: #32550 (comment)

We already have regression test as stated in OP

@etCoderDysto

Payment Summary

@etCoderDysto — paid $250 via Upwork
@aimane-chnaif — to be paid $250 via NewDot

Thanks all!

@CortneyOfstad

@CortneyOfstad I am still using upwork. Can you please reopen and sort payment? Thanks

@aimane-chnaif

@aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~021988042361978261809

@aimane-chnaif

Payment Summary

Contributor+: @aimane-chnaif paid $250 via Upwork

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-24] [$250] Split tax - Tax amount is negative when manually entering tax amount when splitting expense #44632

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

32 remaining items

Payment Summary

BugZero Checklist (@CortneyOfstad)

Payment Summary

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<MenuItemWithTopDescription
	key={`${taxRates?.name}${formattedTaxAmount}`}
	shouldShowRightIcon={canModifyTaxFields}
	title={formattedTaxAmount}

[HOLD for payment 2024-07-24] [$250] Split tax - Tax amount is negative when manually entering tax amount when splitting expense #44632

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 28, 2024

lanitochka17 commented on Jun 28, 2024

lanitochka17 commented on Jun 28, 2024

etCoderDysto commented on Jun 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nkdengineer commented on Jul 1, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 1, 2024

CortneyOfstad commented on Jul 2, 2024

melvin-bot commented on Jul 2, 2024

32 remaining items

melvin-bot commented on Jul 24, 2024

Payment Summary

BugZero Checklist (@CortneyOfstad)

CortneyOfstad commented on Jul 24, 2024

etCoderDysto commented on Jul 24, 2024

aimane-chnaif commented on Jul 24, 2024

CortneyOfstad commented on Jul 25, 2024

Payment Summary

aimane-chnaif commented on Oct 3, 2024

mallenexpensify commented on Nov 11, 2025

mallenexpensify commented on Nov 11, 2025

Payment Summary

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions