[HOLD for payment 2024-07-17] [$250] Android - Workspace - Workspace name is not displayed when navigate via join link

@lschurr

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a470@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

[User B] Copy a workspace join link that User A is not a member
[User A] Open the workspace join link

Expected Result:

Workspace name should be displayed when User A open join link

Actual Result:

Workspace name is not displayed when navigate to Workspace via join link until the member is accepted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0138fb5ddd26e517e8
Upwork Job ID: 1807485642236308668
Last Price Increase: 2024-06-30
Automatic offers:

hungvu193 | Reviewer | 102948824
bernhardoj | Contributor | 102948826

Issue Owner

Current Issue Owner: @lschurr

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lschurr

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pending join WS name isn't displayed in small screen.

What is the root cause of that problem?

The requested badge takes the whole space which hides the workspace name. (the green box is the requested badge container box)

The badge view is wrapped with 2 view.

App/src/pages/workspace/WorkspacesListRow.tsx

Lines 145 to 148 in 4622e19

    
           <View style={[styles.flexRow]}> 
        
               {isJoinRequestPending && ( 
        
                   <View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, isNarrow && styles.workspaceListBadge]}> 
        
                       <Badge

The first view, set the the flex1 style. The flex1 style will grow/shrink based on the space. However, the second View wrapper doesn't limit the width.

For example, if we set it to 50px width, then the WS name will be visible. Or if we set the flex1 to the second View, then the WS name will be visible too. But I think we don't have a static width for the container for now and we don't want to set the flex1 because it means it will have equal width between the Requested badge and the WS avatar + name.

What changes do you think we should make in order to solve the problem?

Remove the badge view wrapper flex1 style

App/src/pages/workspace/WorkspacesListRow.tsx

Lines 147 to 148 in 4622e19

    
           <View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, isNarrow && styles.workspaceListBadge]}> 
        
               <Badge

But we have another problem. If you notice, the Requested badge is overflown the green box container and also not centered.

That's because of the workspaceListBadge style, so we need to remove it too.

App/src/styles/index.ts

Lines 3357 to 3361 in 4622e19

    
           workspaceListBadge: { 
        
               flexDirection: 'column', 
        
               justifyContent: 'flex-start', 
        
               marginTop: 6, 
        
           },

Last, another existing issue in large screen the requested badge doesn't have the same width as the 3-dot.

We can add padding left of 20 to the badge (large screen only) or have a static width for it, for example 128 (the 3-dot width).

Result on small screen

Job added to Upwork: https://www.upwork.com/jobs/~0138fb5ddd26e517e8

@hungvu193

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

I'll review today!

@hungvu193

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix pending join workspace name is not displayed #44716

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment automatic offer (Reviewer)
@bernhardoj requires payment automatic offer (Contributor)

@hungvu193

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
[@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hungvu193] Determine if we should create a regression test for this bug.
[@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The payment should be due tomorrow (07-17)

Requested in ND.

@lschurr

@lschurr I will also request on ND, I'll withdraw my upwork offer.

The PR that introduced the bug has been identified. Link to the PR: fix: Workspace - RBR is aligned to top of WS bar. #42017
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:https://github.com/Expensify/App/pull/42017/files#r1680353812
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: YES

Regression test:

[User B] Copy a workspace join link that User A is not a member.
[User A] Open the workspace join link (On a mobile device).
Verify that workspace name display correctly.

Do we 👍 or 👎

@bernhardoj

Payment summary:

Contributor: @bernhardoj $250 (To be paid in NewDot)
Reviewer: @hungvu193 $250 (To be paid in NewDot)

Added QA test request. Closing :)

@bernhardoj

$250 approved for @bernhardoj

@hungvu193

$250 approved for @hungvu193

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-17] [$250] Android - Workspace - Workspace name is not displayed when navigate via join link #44639

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<View style={[styles.flexRow]}>
	{isJoinRequestPending && (
	<View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, isNarrow && styles.workspaceListBadge]}>
	<Badge

	workspaceListBadge: {
	flexDirection: 'column',
	justifyContent: 'flex-start',
	marginTop: 6,
	},

[HOLD for payment 2024-07-17] [$250] Android - Workspace - Workspace name is not displayed when navigate via join link #44639

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 28, 2024

lanitochka17 commented on Jun 28, 2024

bernhardoj commented on Jun 29, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Jun 30, 2024

melvin-bot commented on Jun 30, 2024

hungvu193 commented on Jul 1, 2024

22 remaining items

melvin-bot commented on Jul 15, 2024

melvin-bot commented on Jul 15, 2024

bernhardoj commented on Jul 16, 2024

bernhardoj commented on Jul 17, 2024

hungvu193 commented on Jul 17, 2024

hungvu193 commented on Jul 17, 2024

lschurr commented on Jul 17, 2024

lschurr commented on Jul 17, 2024

JmillsExpensify commented on Jul 19, 2024

JmillsExpensify commented on Jul 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions