[HOLD for payment 2024-08-02] [$250] Concierge chat is read as it's selected during the onboarding flow

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

Navigate to https://staging.new.expensify.com/
Log in with a new Gmail account
Choose "Something else" on the onboarding modal

Expected Result:

Concierge chat should be BOLD/UNREAD as the user didn't select the chat yet.

Actual Result:

Concierge chat is read as it's selected during the onboarding flow. When the onboarding option is selected, "Expensify" is auto opened from the LHN so Concierge becomes UNBOLD/READ

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

343725496-bfa52b82-54b1-412f-b9e1-ba7591d58c2f.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011f41040f43fc1324
Upwork Job ID: 1810426799057333975
Last Price Increase: 2024-07-08
Automatic offers:

DylanDylann | Reviewer | 103085030
dominictb | Contributor | 103085032

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Concierge chat is read as it's selected during the onboarding flow. When the onboarding option is selected, "Expensify" is auto opened from the LHN so Concierge becomes read.

What is the root cause of that problem?

At the first time users login to App, we have the logic to get the opened report in

App/src/hooks/useLastAccessedReportID.ts

Line 133 in bedfeac

return ReportUtils.findLastAccessedReport(

we're trying to remove the system chat in

App/src/libs/ReportUtils.ts

Lines 1228 to 1233 in bedfeac

    
           // If we only have two reports and one of them is the system chat, filter it out so we don't 
        
           // overwrite showing the concierge chat 
        
           const hasSystemChat = sortedReports.find((report) => isSystemChat(report)) ?? false; 
        
           if (sortedReports.length === 2 && hasSystemChat) { 
        
               sortedReports = sortedReports.filter((report) => !isSystemChat(report)) ?? []; 
        
           }

so the concierge chat is always opened -> it's read

But after complete the onboard flow, we open the system chat if the account id is odd

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Lines 74 to 77 in bedfeac

    
           if (AccountUtils.isAccountIDOddNumber(accountID ?? 0)) { 
        
               Report.navigateToSystemChat(); 
        
           } else { 
        
               Report.navigateToConciergeChat();

In this case, the accountID is odd -> system chat is opened

What changes do you think we should make in order to solve the problem?

We should keep the opened report consistency.

Solution 1: Keep open the concierge chat

Remove these logic

Solution 2: Keep open the system chat if account id is odd, otherwise concierge

In findLastAccessedReport function, we can check if the onboarding flow (NVP_ONBOARDING) is not complete, we can simply return the report based on this logic

    if (shouldUseOnboardFlow) {
        if (AccountUtils.isAccountIDOddNumber(currentUserAccountID ?? 0)) {
            return getSystemChat()
        } else {
            return Object.values(allReports ?? {}).find((report) => isConciergeChatReport(report));
        }
    }

shouldUseOnboardFlow = !isSmallScreenWidth && !hasCompletedGuidedSetupFlow

What alternative solutions did you explore? (Optional)

For solution 2, isFirstTimeNewExpensifyUser can be used but it's always false -> need to be fixed from BE side
We can check if the onboarding flow is not complete, then prevent reading newest action.

I'm not able to reproduce this - the chat has a green icon meaning it's not read

2024-07-02_12-55-05.mp4

asking QA to test again - https://expensify.slack.com/archives/C9YU7BX5M/p1719946606312839

@Christinadobrzyn

@Christinadobrzyn tester is still able to reproduce

bandicam.2024-07-02.21-14-26-792.mp4

@dominictb

I'm still not able to reproduce this - @dominictb are you able to reproduce this?

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@Christinadobrzyn

@Christinadobrzyn Yes, I still can reproduce

@dominictb

Thanks @dominictb I'm confused what I am doing differently here #44728 (comment) there must be a setting or something?

I'm no longer seeing the three LHN chats -

@Christinadobrzyn

@Christinadobrzyn It depends on the accountID, if's odd value, we'll be redirected to system chat. I also mentioned it in my proposal:

But after complete the onboard flow, we open the system chat if the account id is odd

I don't have the consistent way to reproduce. You can try to create the new account several time util it's the odd accountID. Hope this help

@Christinadobrzyn

@Christinadobrzyn Can you reproduce this issue with the context above?

Reviewing label has been removed, please complete the "BugZero Checklist".

@DylanDylann

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: open the correct chat during onboarding flow #45372

If no regressions arise, payment will be issued on 2024-08-02. 🎊

For reference, here are some details about the assignees on this issue:

@DylanDylann requires payment automatic offer (Reviewer)
@dominictb requires payment automatic offer (Contributor)

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@dominictb

Payouts due:

Contributor: $250 @dominictb (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/37820143/overview)
Contributor+: $250 @DylanDylann (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/37802598/overview)

@DylanDylann do we need a regression test?

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. No
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Do we agree 👍 or 👎

@thienlnam

Paid this out based on this payment summary - #44728 (comment)

I'll leave this open for @thienlnam or @dominictb to give an opinion on #44728 (comment)

Then we can close it out!

let's close this out without a regression test.

@dominictb

@dominictb This PR caused another bug

BUG: Infinity loading in the second login

Login
Logout
Login again
Infinity loading happen on the main screen

Screen.Recording.2024-08-22.at.16.09.21.mov

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-02] [$250] Concierge chat is read as it's selected during the onboarding flow #44728

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

36 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// If we only have two reports and one of them is the system chat, filter it out so we don't
	// overwrite showing the concierge chat
	const hasSystemChat = sortedReports.find((report) => isSystemChat(report)) ?? false;
	if (sortedReports.length === 2 && hasSystemChat) {
	sortedReports = sortedReports.filter((report) => !isSystemChat(report)) ?? [];
	}

	if (AccountUtils.isAccountIDOddNumber(accountID ?? 0)) {
	Report.navigateToSystemChat();
	} else {
	Report.navigateToConciergeChat();

[HOLD for payment 2024-08-02] [$250] Concierge chat is read as it's selected during the onboarding flow #44728

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 2, 2024

dominictb commented on Jul 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Christinadobrzyn commented on Jul 2, 2024

kavimuru commented on Jul 2, 2024

Christinadobrzyn commented on Jul 2, 2024

MelvinBot commented on Jul 2, 2024

dominictb commented on Jul 3, 2024

Christinadobrzyn commented on Jul 3, 2024

dominictb commented on Jul 4, 2024

dominictb commented on Jul 4, 2024

dominictb commented on Jul 8, 2024

36 remaining items

melvin-bot commented on Jul 26, 2024

melvin-bot commented on Jul 26, 2024

melvin-bot commented on Jul 26, 2024

Christinadobrzyn commented on Aug 1, 2024

DylanDylann commented on Aug 2, 2024

Christinadobrzyn commented on Aug 2, 2024

Christinadobrzyn commented on Aug 5, 2024

DylanDylann commented on Aug 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions