You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[CHECKLIST - ISHPAUL] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod #44765
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@jliexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][HOLD for payment 2024-07-17] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/+]on Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ishpaul777] Determine if we should create a regression test for this bug.
[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/-][+][CHECKLIST - ISHPAUL] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/+]on Jul 19, 2024
[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: The bug is upstream and there was no specific change in the PR that triggered it
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[@ishpaul777] Determine if we should create a regression test for this bug. Not required
[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. - N/A
Activity
melvin-bot commentedon Jul 3, 2024
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 3, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jul 3, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Jul 3, 2024
@jliexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Jul 3, 2024
We think this issue might be related to the #vip-vsb
izarutskaya commentedon Jul 3, 2024
Production
56 remaining items
[-][HOLD for payment 2024-07-17] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/+]melvin-bot commentedon Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jliexpensify commentedon Jul 18, 2024
Bump @ishpaul777 for the checklist!
Payment Summary
Upwork job
jliexpensify commentedon Jul 19, 2024
Paid and job closed. Bump @ishpaul777 for the checklist.
[-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/-][+][CHECKLIST - ISHPAUL] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/+]ishpaul777 commentedon Jul 19, 2024
will complete checklist today for sure 👍
ishpaul777 commentedon Jul 19, 2024
jliexpensify commentedon Jul 20, 2024
Thanks, closing!