Skip to content

[CHECKLIST - ISHPAUL] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod #44765

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.3-6
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): gatantm+82@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to any chat
  2. Click on the plus icon > Assign task
  3. Add any Title > next
  4. Second flow click on the chat header > Share

Expected Result:

The second page of the opened RHP is shown without issues

Actual Result:

The second page of the opened RHP either when assigning a task or Sharing a channel is shown cut. Sometimes the button back is hard to reach as well

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6531549_1719964113484.Recording__959.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c408a04e30a45b7f
  • Upwork Job ID: 1808446874734237891
  • Last Price Increase: 2024-07-03
  • Automatic offers:
    • ishpaul777 | Contributor | 102994015
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 3, 2024
  2. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jul 3, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jul 3, 2024

    @izarutskaya
    Author

    @jliexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Jul 3, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb

  7. izarutskaya commented on Jul 3, 2024

    @izarutskaya
    Author

    Production

    Screenshot 2024-07-03 at 08 00 22

  8. 56 remaining items

  9. changed the title [-][HOLD for payment 2024-07-17] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/-] [+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/+] on Jul 15, 2024
  10. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-22. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ishpaul777] Determine if we should create a regression test for this bug.
    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. jliexpensify commented on Jul 18, 2024

    @jliexpensify
    Contributor

    Bump @ishpaul777 for the checklist!

    Payment Summary

    Upwork job

  13. jliexpensify commented on Jul 19, 2024

    @jliexpensify
    Contributor

    Paid and job closed. Bump @ishpaul777 for the checklist.

  14. changed the title [-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/-] [+][CHECKLIST - ISHPAUL] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod[/+] on Jul 19, 2024
  15. ishpaul777 commented on Jul 19, 2024

    @ishpaul777
    Contributor

    will complete checklist today for sure 👍

  16. ishpaul777 commented on Jul 19, 2024

    @ishpaul777
    Contributor
    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: Enable React concurrent mode #42592
    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: The bug is upstream and there was no specific change in the PR that triggered it
    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
    • [@ishpaul777] Determine if we should create a regression test for this bug. Not required
    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. - N/A
  17. jliexpensify commented on Jul 20, 2024

    @jliexpensify
    Contributor

    Thanks, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions