[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Search - The Select all checbox is not checked when all the expenses are checked

@dukenv0307

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

issue found when validating 44385
Version Number: 9.0.4.0
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

User has paid and unpaid expenses.

Go to staging.new.expensify.com
Go to Search > Expenses.
Click on Select all checkbox.

Expected Result:

The Select all checbox will be checked when all the expenses are checked.

Actual Result:

The Select all checbox is not checked when all the expenses are checked.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6532517_1720043062739.20240704_054243.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cc02085472b9db82
Upwork Job ID: 1808737057762476275
Last Price Increase: 2024-07-04
Automatic offers:

dukenv0307 | Reviewer | 102993219
nkdengineer | Contributor | 102993222
c3024 | Contributor | 102998392

Issue Owner

Current Issue Owner: @dukenv0307

@techievivek

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@mallenexpensify

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Select all checbox is not checked when all the expenses are checked.

What is the root cause of that problem?

The item in expenses search doesn't have the text field

So when all items are checked, only one is added to selectedOptions array

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 169 to 171 in 83eb7e6

    
           if (item.isSelected && !selectedOptions.find((option) => option.text === item.text)) { 
        
               selectedOptions.push(item); 
        
           }

And then allSelected is false which makes the all checkbox is not checked

App/src/components/SelectionList/BaseSelectionList.tsx

Line 195 in 83eb7e6

    
           allSelected: selectedOptions.length > 0 && selectedOptions.length === allOptions.length - disabledOptionsIndexes.length,

What changes do you think we should make in order to solve the problem?

We should compare the keyForList field here instead of the text field

if (item.isSelected && !selectedOptions.find((option) => option.keyForList === item.keyForList)) {
    selectedOptions.push(item);
}

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 169 to 171 in 83eb7e6

    
           if (item.isSelected && !selectedOptions.find((option) => option.text === item.text)) { 
        
               selectedOptions.push(item); 
        
           }

For the search like shared, draft, finished, we should add the keyForList to the item when we get the report section here

reportIDToTransactions[reportKey] = {
    ...value,
    keyForList: value.reportID,S
    from: data.personalDetailsList?.[value.accountID],
    to: data.personalDetailsList?.[value.managerID],
    transactions,
};

App/src/libs/SearchUtils.ts

Line 167 in a84f68e

reportIDToTransactions[reportKey] = {

What alternative solutions did you explore? (Optional)

Or we can add the text field to each item in expense search page

@dukenv0307

@dukenv0307 why don't we want a test case for this?

@mallenexpensify

@mallenexpensify I think the test case is already mentioned in the OP

The checklist says N/A and it sounds like we likely want one. If it's the same as the in the OP of the issue or PR, please copy/paste below the BZ checklist, you're more familiar with the test steps and the BZ shouldn't assume the steps in the OP are up to date and accurate. Thx

@luacmartins

@luacmartins, @mallenexpensify, @mountiny, @dukenv0307, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins

@luacmartins, @mallenexpensify, @mountiny, @dukenv0307, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...

@luacmartins

@luacmartins, @mallenexpensify, @mountiny, @dukenv0307, @nkdengineer Still overdue 6 days?! Let's take care of this!

@dukenv0307

@dukenv0307 👀 plz

The checklist says N/A and it sounds like we likely want one. If it's the same as the in the OP of the issue or PR, please copy/paste below the BZ checklist, you're more familiar with the test steps and the BZ shouldn't assume the steps in the OP are up to date and accurate. Thx

@mallenexpensify

Thank you @mallenexpensify. I edited the checklists. I'll add the regression steps for the other checklists

@luacmartins

@luacmartins, @mallenexpensify, @mountiny, @dukenv0307, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@dukenv0307

Thanks @dukenv0307. All set

https://github.com/Expensify/Expensify/issues/416874

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Search - The Select all checbox is not checked when all the expenses are checked #44801

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

49 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (item.isSelected && !selectedOptions.find((option) => option.text === item.text)) {
	selectedOptions.push(item);
	}

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Search - The Select all checbox is not checked when all the expenses are checked #44801

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 4, 2024

melvin-bot commented on Jul 4, 2024

github-actions commented on Jul 4, 2024

m-natarajan commented on Jul 4, 2024

m-natarajan commented on Jul 4, 2024

nkdengineer commented on Jul 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

49 remaining items

mallenexpensify commented on Jul 19, 2024

dukenv0307 commented on Jul 19, 2024

mallenexpensify commented on Jul 20, 2024

melvin-bot commented on Jul 22, 2024

melvin-bot commented on Jul 24, 2024

melvin-bot commented on Jul 26, 2024

mallenexpensify commented on Jul 26, 2024

dukenv0307 commented on Jul 27, 2024

melvin-bot commented on Jul 30, 2024

mallenexpensify commented on Jul 31, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions