[HOLD for payment 2024-07-17] Wallet - Error page overlaps with device status bar

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

issue found when validating #44628
Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Launch New Expensify app.
Go to Account settings > Wallet.
Click Enable Wallet.
Log in to Wells Fargo.
Proceed to idology sections.
Answer all idology questions incorrectly.

Expected Result:

The error page will not overlap with device status bar.

Actual Result:

The error page overlaps with device status bar.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6532547_1720047126063.44628_iOS.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@hayata-suenaga

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@hayata-suenaga

@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error page overlaps with device status bar.

What is the root cause of that problem?

We're missing ScreenWrapper:

App/src/pages/EnablePayments/EnablePayments.tsx

Lines 41 to 47 in 423544d

    
           <> 
        
               <HeaderWithBackButton 
        
                   title={translate('personalInfoStep.personalInfo')} 
        
                   onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)} 
        
               /> 
        
               <FailedKYC /> 
        
           </>

What changes do you think we should make in order to solve the problem?

Wrap ScreenWrapper over the above snippet.

@hoangzinh

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Checklist time!

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR: Refactor/36648 wallet enablement flow connect steps #42589
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42589/files#r1684260094
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: ⛔ No I think it's a small UI issue.

@hoangzinh

@hoangzinh, @trjExpensify, @koko57, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@hoangzinh

Thanks! Confirming payments as follows:

$250 to @hoangzinh for the C+ review

Offer sent!

@trjExpensify

Accepted. Thanks @trjExpensify

Paid, closing!

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-17] Wallet - Error page overlaps with device status bar #44805

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

25 remaining items

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<>
	<HeaderWithBackButton
	title={translate('personalInfoStep.personalInfo')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}
	/>
	<FailedKYC />
	</>

[HOLD for payment 2024-07-17] Wallet - Error page overlaps with device status bar #44805

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 4, 2024

melvin-bot commented on Jul 4, 2024

github-actions commented on Jul 4, 2024

m-natarajan commented on Jul 4, 2024

m-natarajan commented on Jul 4, 2024

gijoe0295 commented on Jul 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

25 remaining items

melvin-bot commented on Jul 15, 2024

trjExpensify commented on Jul 19, 2024

hoangzinh commented on Jul 19, 2024

BugZero Checklist:

melvin-bot commented on Jul 22, 2024

trjExpensify commented on Jul 22, 2024

hoangzinh commented on Jul 24, 2024

trjExpensify commented on Jul 24, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions