[HOLD for payment 2024-07-17] [$125] Invoice-User B's workspace appears in User A's workspace list after paying invoice as business

@kevinksullivan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

User A and User B have their own workspaces.

Go to staging.new.expensify.com
[User A] Send invoice to User B.
[User B] Go to invoice chat.
[User B] Click on the pay button > Pay as a business > Pay elsewhere.
[User A] Go to Account settings > Workspaces.

Expected Result:

User B's workspace will not appear in User A's workspace list.

Actual Result:

User B's workspace appears in User A's workspace list after paying invoice as a business.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6532630_1720057513028.20240704_094220.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011ae1abcb3755a5ef
Upwork Job ID: 1808845128155915041
Last Price Increase: 2024-07-04

Issue Owner

Current Issue Owner: @kevinksullivan

@flodnv

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kevinksullivan

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@kevinksullivan

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #vip-vsb.

Production

@kevinksullivan

I believe the payment was already due as of 2024-07-17

You're right. @kevinksullivan could you please handle the payments? 🙏

@eVoloshchak

@eVoloshchak, @cristipaval, @kevinksullivan, @nyomanjyotisa Whoops! This issue is 2 days overdue. Let's get this updated quick!

@nyomanjyotisa

Offer sent to @nyomanjyotisa . @eVoloshchak can you complete the checklist please?

@eVoloshchak

Payment summary:

@eVoloshchak $150 (ND)
@nyomanjyotisa $150

Offer accepted

@eVoloshchak

Paid. Waiting on checklist @eVoloshchak

The PR that introduced the bug has been identified. Link to the PR: [Wave 8] Ideal nav #33280
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/33280/files#r1686570145
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed as this is a minor edge case

Regression Test Proposal

Prerequisite: User A and User B have their own workspaces.

[User A] Send invoice to User B.
[User B] Go to invoice chat.
[User B] Click on the pay button > Pay as a business > Pay elsewhere.
[User A] Go to Account settings > Workspaces.
Verify that User B's workspace does not appear in the workspace list

Do we agree 👍 or 👎

@eVoloshchak

$150 approved for @eVoloshchak

@eVoloshchak

@eVoloshchak, @cristipaval, @kevinksullivan, @nyomanjyotisa Whoops! This issue is 2 days overdue. Let's get this updated quick!

@eVoloshchak

@eVoloshchak, @cristipaval, @kevinksullivan, @nyomanjyotisa Eep! 4 days overdue now. Issues have feelings too...

adding regression test and closing out!

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-17] [$125] Invoice-User B's workspace appears in User A's workspace list after paying invoice as business #44811

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

44 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-17] [$125] Invoice-User B's workspace appears in User A's workspace list after paying invoice as business #44811

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 4, 2024

melvin-bot commented on Jul 4, 2024

github-actions commented on Jul 4, 2024

izarutskaya commented on Jul 4, 2024

izarutskaya commented on Jul 4, 2024

izarutskaya commented on Jul 4, 2024

44 remaining items

cristipaval commented on Jul 19, 2024

melvin-bot commented on Jul 19, 2024

kevinksullivan commented on Jul 19, 2024

kevinksullivan commented on Jul 19, 2024

nyomanjyotisa commented on Jul 19, 2024

kevinksullivan commented on Jul 19, 2024

eVoloshchak commented on Jul 22, 2024

JmillsExpensify commented on Jul 22, 2024

melvin-bot commented on Jul 23, 2024

melvin-bot commented on Jul 25, 2024

kevinksullivan commented on Jul 25, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions