Skip to content

[HOLD for payment 2024-07-24] [ESM] Expense - System message for receipt removal is different in expense report and LHN preview #44817

New issue
New issue
Closed
Closed
[HOLD for payment 2024-07-24] [ESM] Expense - System message for receipt removal is different in expense report and LHN preview#44817
Assignees
jliexpensifygrgia
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Description

@izarutskaya
izarutskaya
opened on Jul 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4693737
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat.
  3. Submit an expense with receipt.
  4. Go to transaction thread.
  5. Click on the receipt.
  6. Click 3-dot menu > Delete receipt.
  7. Delete the receipt.
  8. Return to expense report.

Expected Result:

The system message for receipt removal will be the same in the report and LHN.

Actual Result:

The system message for receipt removal is "removed the receipt" in the report, while it shows "detached a receipt from expense '(none)'" in LHN.
When copied to clipboard, it shows "You detached a receipt from expense '(none)'" instead.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6532839_1720079856793.bandicam_2024-07-04_15-53-33-348.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 4, 2024

  2. melvin-bot commented on Jul 4, 2024

    @melvin-bot
    melvin-botBot
    on Jul 4, 2024 – with Melvin Bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot
    assigned
    grgia
    and
    jliexpensify
    on Jul 4, 2024

  4. melvin-bot commented on Jul 4, 2024

    @melvin-bot
    melvin-botBot
    on Jul 4, 2024 – with Melvin Bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Jul 4, 2024

  6. github-actions commented on Jul 4, 2024

    @github-actions
    github-actionsBot
    on Jul 4, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  7. izarutskaya commented on Jul 4, 2024

    @izarutskaya
    izarutskaya
    on Jul 4, 2024
    Author

    @jliexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  8. izarutskaya commented on Jul 4, 2024

    @izarutskaya
    izarutskaya
    on Jul 4, 2024
    Author

    We think this issue might be related to the #collect project.

  9. grgia commented on Jul 4, 2024

    @grgia
    grgia
    on Jul 4, 2024
    Contributor

    @bernhardoj could this be related to #43079 ?

  10. 27 remaining items

  11. melvin-bot
    changed the title [-][ESM] Expense - System message for receipt removal is different in expense report and LHN preview[/-] [+][HOLD for payment 2024-07-24] [ESM] Expense - System message for receipt removal is different in expense report and LHN preview[/+] on Jul 17, 2024
  12. melvin-bot
    removed
    ReviewingHas a PR in review
    on Jul 17, 2024

  13. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botBot
    on Jul 17, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botBot
    on Jul 17, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

  15. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botBot
    on Jul 17, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@grgia] The PR that introduced the bug has been identified. Link to the PR:
    • [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@grgia] Determine if we should create a regression test for this bug.
    • [@grgia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  16. jliexpensify commented on Jul 23, 2024

    @jliexpensify
    jliexpensify
    on Jul 23, 2024
    Contributor

    Payment Summary

  17. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jul 23, 2024

  18. melvin-bot commented on Jul 24, 2024

    @melvin-bot
    melvin-botBot
    on Jul 24, 2024 – with Melvin Bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  19. jliexpensify commented on Jul 25, 2024

    @jliexpensify
    jliexpensify
    on Jul 25, 2024
    Contributor

    Bumping @grgia or @sobitneupane to confirm if payments are needed!

  20. sobitneupane commented on Jul 25, 2024

    @sobitneupane
    sobitneupane
    on Jul 25, 2024
    Contributor

    @jliexpensify I reviewed the PR linked with this issue. I will request payment in newDot.

  21. jliexpensify commented on Jul 25, 2024

    @jliexpensify
    jliexpensify
    on Jul 25, 2024
    Contributor

    Nice, ok the payment summary is correct then. Thanks!

  22. jliexpensify
    closed this as completedon Jul 25, 2024
  23. github-project-automation
    moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Jul 25, 2024

  24. JmillsExpensify commented on Jul 29, 2024

    @JmillsExpensify
    JmillsExpensify
    on Jul 29, 2024
    Contributor

    $250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions