Skip to content

[HOLD for payment 2024-07-22] [$250] Invoice - App crashes after receiver deletes all workspaces and sender is unable to send invoice #44818

New issue
New issue
Closed
Closed
[HOLD for payment 2024-07-22] [$250] Invoice - App crashes after receiver deletes all workspaces and sender is unable to send invoice#44818
Assignees
carlosmicelicristipavalmuttmuurec3024
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@izarutskaya
izarutskaya
opened on Jul 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #43036
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • User A and User B have their own workspace.
  1. Go to staging.new.expensify.com
  2. [User A] Send an invoice to User B.
  3. [User B] Go to invoice chat.
  4. [User B] Click pay button > Pay the invoice as business > Pay elsewhere.
  5. [User A] Send another invoice.
  6. [User A] Note that User A can send another invoice.
  7. [User B] Delete all the workspaces.
  8. [User B] Note that app crashes after deleting the workspace.
  9. [User A] Send another invoice to User B in the same workspace chat.
  10. [User A] Note that user cannot send invoice after User B deletes all the workspaces.
  11. [User B] Go to Account settings > Workspaces.
  12. [User B] Note that the workspace list shows blank workspace under Free plan.

Expected Result:

In Step 8, app will not crash after user B deletes all the workspaces.
In Step 10, User A should be able to send another invoice to User B after user B deletes all the workspaces.
In Step 12, there should not be any workspace in the list.

Actual Result:

In Step 8, app crashes after user B deletes all the workspaces.
In Step 10, User A is unable to send another invoice to User B after user B deletes all the workspaces.
In Step 12, there is a blank workspace under Free plan.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6532944_1720087574886.bandicam_2024-07-04_17-59-00-716.mp4

Bug6532944_1720087574902!staging.new.expensify.com-1720087225348.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015e8883cec9f5dd20
  • Upwork Job ID: 1808990503832944883
  • Last Price Increase: 2024-07-04
  • Automatic offers:
    • c3024 | Contributor | 103001035
Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 4, 2024
  2. melvin-bot
    assigned
    muttmuure
    and
    carlosmiceli
    on Jul 4, 2024

  3. melvin-bot commented on Jul 4, 2024

    @melvin-bot
    melvin-botBot
    on Jul 4, 2024 – with Melvin Bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jul 4, 2024

    @melvin-bot
    melvin-botBot
    on Jul 4, 2024 – with Melvin Bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Jul 4, 2024

  6. github-actions commented on Jul 4, 2024

    @github-actions
    github-actionsBot
    on Jul 4, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  7. izarutskaya commented on Jul 4, 2024

    @izarutskaya
    izarutskaya
    on Jul 4, 2024
    Author

    @muttmuure I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  8. izarutskaya commented on Jul 4, 2024

    @izarutskaya
    izarutskaya
    on Jul 4, 2024
    Author

    We think this issue might be related to the #collect project. #vip-bills

  9. carlosmiceli
    removed
    DeployBlockerIndicates it should block deploying the API
    on Jul 4, 2024

  10. 60 remaining items

  11. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jul 15, 2024
  12. melvin-bot
    changed the title [-][$250] Invoice - App crashes after receiver deletes all workspaces and sender is unable to send invoice[/-] [+][HOLD for payment 2024-07-22] [$250] Invoice - App crashes after receiver deletes all workspaces and sender is unable to send invoice[/+] on Jul 15, 2024

  13. melvin-bot commented on Jul 15, 2024

    @melvin-bot
    melvin-botBot
    on Jul 15, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-22. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jul 15, 2024

    @melvin-bot
    melvin-botBot
    on Jul 15, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR:
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@c3024] Determine if we should create a regression test for this bug.
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Jul 22, 2024

  16. carlosmiceli commented on Jul 24, 2024

    @carlosmiceli
    carlosmiceli
    on Jul 24, 2024
    Contributor

    @c3024 small bump :)

  17. c3024 commented on Jul 25, 2024

    @c3024
    c3024
    on Jul 25, 2024
    Contributor
    • [@c3024] The PR that introduced the bug has been identified. Link to the PR: This is a revert PR for Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace #43036. The authors are aware that the PR was reverted.
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No, this is not a bug that could be identified earlier with any steps.
    • [@c3024] Determine if we should create a regression test for this bug. This was identified during staging regression tests. So, no regression test is required.
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. NA

  18. muttmuure commented on Jul 25, 2024

    @muttmuure
    muttmuure
    on Jul 25, 2024
    Contributor

    Paid

  19. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Jul 25, 2024
  20. muttmuure
    closed this as completedon Jul 29, 2024
  21. melvin-bot
    removed
    Overdue
    on Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions