Repository navigation
[$250] Chat - Error message reappears after sending another message #44824
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4693768
Email or phone of affected tester (no customers): vdargentotest+web070324@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
- Go to any chat.
- Send a corrupted PDF file (there is one attached to this report).
- Verify an error message appears.
- Dismiss the error message by clicking on the "x" icon.
- Send another message.
- Verify the error message that was already dismissed reappears.
Expected Result:
The error message should not reappear.
Actual Result:
The error message reappears after sending another message.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6532542_1720046830416.bandicam_2024-07-03_18-41-01-357.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0167c1b57ade6a9fb4
- Upwork Job ID: 1810456336736930787
- Last Price Increase: 2024-07-15
- Automatic offers:
- alitoshmatov | Reviewer | 103158918
- nyomanjyotisa | Contributor | 103158919
Activity
melvin-bot commentedon Jul 4, 2024
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon Jul 4, 2024
We think this issue might be related to the #vip-vsb
VictoriaExpensify commentedon Jul 5, 2024
I haven't had a chance to look at this, will come back to it on Monday
nyomanjyotisa commentedon Jul 7, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Error message reappears after sending another message
What is the root cause of that problem?
There is an error when uploading attachment:
This happens because we directly assigning the
fileobject (which contains non-clonable properties) toattachmentInfowhich we use onoptimisticDataThis cause an error because we cannot store non-cloneable properties on IndexedDB
This make the reportActions_ onyx data not stored on IndexedDB
What changes do you think we should make in order to solve the problem?
App/src/libs/ReportUtils.ts
Line 3702 in 4ae133d
Change this code to
const attachmentInfo = file ? {...file} : {};by this changes we create a shallow copy of the file object. This shallow copy contains only the properties of the file object, excluding any non-clonable propertiesRESULT
New-Expensify.13.mp4
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Jul 8, 2024
@VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jul 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0167c1b57ade6a9fb4
[-] Chat - Error message reappears after sending another message[/-][+][$250] Chat - Error message reappears after sending another message[/+]melvin-bot commentedon Jul 8, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (
External)23 remaining items
nyomanjyotisa commentedon Jul 17, 2024
PR created @alitoshmatov
nyomanjyotisa commentedon Jul 23, 2024
bump for PR review @alitoshmatov
cead22 commentedon Aug 6, 2024
The PR was closed because the issue got fixed elsewhere. That said, contributors should still receive payement. @VictoriaExpensify can you handle that please?
mallenexpensify commentedon Aug 6, 2024
@VictoriaExpensify both @nyomanjyotisa and @alitoshmatov are due compensation here. Per the internal SO
melvin-bot commentedon Aug 12, 2024
This issue has not been updated in over 15 days. @cead22, @VictoriaExpensify, @alitoshmatov, @nyomanjyotisa eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
ahmedGaber93 commentedon Aug 19, 2024
We have the same issue after uploading workspace avatar here #47150. Is it should fix here? Asking because we have an accepted proposal here, but nothing there.
@cead22 @alitoshmatov @nyomanjyotisa
alitoshmatov commentedon Aug 27, 2024
It does look like both are similar, not sure if our solution would have solved this though. @nyomanjyotisa Can you look into #47150 issue
ahmedGaber93 commentedon Sep 2, 2024
@nyomanjyotisa bump #44824 (comment)
alitoshmatov commentedon Sep 3, 2024
#47150 (comment) They decided to handle the issue there.
Next step for this issue is to handle payment and close the issue
cc: @VictoriaExpensify
mallenexpensify commentedon Sep 4, 2024
@VictoriaExpensify plz pay both @alitoshmatov and @nyomanjyotisa since @nyomanjyotisa was hired and raised a PR, only for the bug to fixed magically (right?) Carlos commented here too
VictoriaExpensify commentedon Sep 11, 2024
Payment Summary:
Contributor: @nyomanjyotisa paid $250 via Upwork
Contributor+: @alitoshmatov paid $250 via Upwork
Upwork Job