You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Hold - "Confirm payment amount" modal appears on top of Troubleshoot menu #44828
Please re-state the problem that we are trying to solve in this issue.
The confirm payment amount modal is shown on top of the troubleshoot modal.
What is the root cause of that problem?
This happens to every modal, not limited to confirm payment amount modal. When we press the troubleshoot menu shortcut, we toggle the troubleshoot menu modal visibility.
Activity
melvin-bot commentedon Jul 4, 2024
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon Jul 4, 2024
We think this issue might be related to the #collect project.
bernhardoj commentedon Jul 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The confirm payment amount modal is shown on top of the troubleshoot modal.
What is the root cause of that problem?
This happens to every modal, not limited to confirm payment amount modal. When we press the troubleshoot menu shortcut, we toggle the troubleshoot menu modal visibility.
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 300 to 305 in 74a6dbb
If we see on other shortcuts, we always close the modal first and wait for until it's closed before executing the shortcut navigation.
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 290 to 294 in 74a6dbb
But we don't do it for troubleshoot menu modal shortcuts, so the confirm payment amount or any modal/popover is still visible..
What changes do you think we should make in order to solve the problem?
Wrap the troubleshoot menu shortcut with
Modal.closeRachCHopkins commentedon Jul 9, 2024
Just clarifying internally on this one as it's not customer-facing.
RachCHopkins commentedon Jul 9, 2024
Closing per internal discussion.