[HOLD for payment 2024-07-26] [$250] Send invoice - "Choose a payment method" disappears after returning from Pay elsewhere page

@sonialiap

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR : #43036
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Go to staging.new.expensify.com
[User A] Send an invoice to user B.
[User B] Go to invoice chat.
[User B] Click Pay button.
[User B] Click Pay as individual or Pay as business.
[User B] Click on the back button.

Expected Result:

"Choose a payment method below" in the payment method selection page will persist.

Actual Result:

"Choose a payment method below" in the payment method selection page disappears.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6532611_1720055363822.20240704_090314.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ace2c2d5df911f17
Upwork Job ID: 1809200291724480759
Last Price Increase: 2024-07-05
Automatic offers:

cretadn22 | Contributor | 103046339

Issue Owner

Current Issue Owner: @sonialiap

@sonialiap

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think this issue might be related to the #vip-bills.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Choose a payment method below" in the payment method selection page disappears.

What is the root cause of that problem?

We don't use setState when click back button in

App/src/components/PopoverMenu.tsx

Line 159 in 6ac95e4

enteredSubMenuIndexes.splice(-1);

so state enteredSubMenuIndexes is not updated and popover isn't rendered again

What changes do you think we should make in order to solve the problem?

We should create a function renderHeader() and it'll update header everytime enteredSubMenuIndexes changes

    const renderHeader = () => {
        if(!headerText || enteredSubMenuIndexes.length > 0) {
            return;
        }
        return <Text style={[styles.createMenuHeaderText, styles.ph5, styles.pv3]}>{headerText}</Text>
    }

What alternative solutions did you explore? (Optional)

Using setState in this case

setEnteredSubMenuIndexes((prevState) => prevState.splice(-1))

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Choose a payment method" disappears after returning from Pay elsewhere page

What is the root cause of that problem?

We update enteredSubMenuIndexes state directly

App/src/components/PopoverMenu.tsx

Line 159 in 6ac95e4

enteredSubMenuIndexes.splice(-1);

What changes do you think we should make in order to solve the problem?

Need to utilize setState to adjust the state value

App/src/components/PopoverMenu.tsx

Line 159 in 6ac95e4

enteredSubMenuIndexes.splice(-1);

setEnteredSubMenuIndexes((prevState) => prevState.slice(0, -1))

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~01ace2c2d5df911f17

@mollfpr

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

it would be better if you explain with voice

@sonialiap

@sonialiap please add a payment summary when you get a chance.

@daledah

Since it seems like there was extra work put into this, I'm increasing the base price to $500

Payment summary:

@daledah $250 for the proposal - offer sent in Upwork - paid in Upwork ✔️
@cretadn22 $500 for the fix - paid in Upwork ✔️
@mollfpr $500 for the c+ - please request in ND

Does this sound fair to everyone?

@mollfpr

$500 approved for @mollfpr

@JmillsExpensify

@JmillsExpensify @sonialiap Could you please approve my offer?

@sonialiap

@sonialiap Sounds good to me thanks, could you send the offer to my UW profile here? https://www.upwork.com/freelancers/~0138d999529f34d33f

@daledah

@daledah thanks for the upwork link! Offer sent 💃

@sonialiap

@sonialiap Accepted the offer thx

Everyone has been paid ✔️

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-26] [$250] Send invoice - "Choose a payment method" disappears after returning from Pay elsewhere page #44830

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

38 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-26] [$250] Send invoice - "Choose a payment method" disappears after returning from Pay elsewhere page #44830

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 4, 2024

izarutskaya commented on Jul 4, 2024

daledah commented on Jul 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

cretadn22 commented on Jul 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 5, 2024

melvin-bot commented on Jul 5, 2024

Abdelrahman286 commented on Jul 6, 2024

38 remaining items

JmillsExpensify commented on Jul 29, 2024

sonialiap commented on Jul 30, 2024

JmillsExpensify commented on Jul 30, 2024

cretadn22 commented on Aug 1, 2024

daledah commented on Aug 2, 2024

sonialiap commented on Aug 2, 2024

daledah commented on Aug 3, 2024

sonialiap commented on Aug 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions