Repository navigation
[HOLD for payment 2021-09-16] Desktop - Big empty space in message fields if copy/paste the Text from MAC Note.app #4484
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue was found when executing the PR #4363
Action Performed:
- Navigate to a conversation that has some messages.
- Paste the Text from MAC note.app to the composer.
Expected Result:
Only entered message should be visible in compose field if copy/paste the Text from MAC Note.app
Actual Result:
Big empty space in message compose field if copy/past the Text from MAC Note.app
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Desktop App
Version Number:
v1.0.83-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5182815_empty.mp4
Expensify/Expensify Issue URL:
Activity
OSBotify commentedon Aug 7, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Aug 7, 2021
Triggered auto assignment to @bondydaa (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.bondydaa commentedon Aug 7, 2021
I am OOO
francoisl commentedon Aug 10, 2021
@parasharrajat - just checking, it looks like you were aware of this issue, correct? Was there a separate GH issue that was opened to track the bug where newlines are prepended to messages pasted into the message box?
parasharrajat commentedon Aug 10, 2021
No, a new issue was not opened at that time. I was waiting for #4363 to merge as only after that, this behaviour is revealed.
So with an inspection, I come to know that the Mac Note app. usages
chars to show spaces which are also needed to be escaped and current_.unescapedoes not do that. I think we need a custom implementation as is not made to parse HTMLEntities and its usages do not seem sufficient any more.About the main issue, let me quickly take a good peek at it. Only then I can tell what is causing this much space.
roryabraham commentedon Aug 11, 2021
I think we should demote this from deploy blocker to regular-old 🐛
24 remaining items
johnmlee101 commentedon Aug 30, 2021
Bumping back to weekly while we wait for this to close out
parasharrajat commentedon Sep 7, 2021
I am on vacation. back on 8.
botify commentedon Sep 8, 2021
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
botify commentedon Sep 8, 2021
🚀 Deployed to staging by @johnmlee101 in version: 1.0.94-2 🚀
[-]Desktop - Big empty space in message fields if copy/paste the Text from MAC Note.app[/-][+][HOLD for payment 2021-09-16] Desktop - Big empty space in message fields if copy/paste the Text from MAC Note.app[/+]botify commentedon Sep 9, 2021
🚀 Deployed to production by @yuwenmemon in version: 1.0.95-1 🚀
parasharrajat commentedon Sep 17, 2021
@kadiealexander Any update for Upwork?
kadiealexander commentedon Sep 19, 2021
Sorry @parasharrajat, timezones meant this fell on my weekend! I've paid this now. 💸