[HOLD for payment 2024-08-07] [$250] IOU - Clicking back "on page not found" page takes you to a workspace page

@miljakljajic

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dave0123seife+stest@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Go to a 1:1 Conversation. Make sure your seeing both account at the same time
As user A request money from User B
As user A go the IOU report that was just created and click on the Plus button to bring the menu
While the menu is still open Go to User B and Pay the expense
As user A click on "submit expense" on the menu that was opened in step 3.
Notice the error page is shown.
Click the back button found on the error page

Expected Result:

Clicking back takes you to the IOU report page

Actual Result:

Clicking back "on page not found" page takes you to a workspace page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6534018_1720180967660.ex_IOU_issue.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019f96054ddd649966
Upwork Job ID: 1811060426930703182
Last Price Increase: 2024-07-10
Automatic offers:

nkdengineer | Contributor | 103146401

Issue Owner

Current Issue Owner: @miljakljajic

@miljakljajic

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Clicking back "on page not found" page takes you to a workspace page

What is the root cause of that problem?

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 124 to 130 in ffd72fb

    
           <AccessOrNotFoundWrapper 
        
               reportID={reportID} 
        
               iouType={iouType} 
        
               policyID={policy?.id} 
        
               accessVariants={[CONST.IOU.ACCESS_VARIANTS.CREATE]} 
        
               allPolicies={allPolicies} 
        
           >

We pass policyID on AccessOrNotFoundWrapper for the IOURequestStartPage

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 98 in ffd72fb

    
           onBackButtonPress={() => Navigation.goBack(policyID ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined)}

Because the policyID exist it will navigate to ROUTES.WORKSPACE_PROFILE.getRoute(policyID) on back button press

What changes do you think we should make in order to solve the problem?

Remove the policyID on AccessOrNotFoundWrapper for the IOURequestStartPage so it will navigate back

       <AccessOrNotFoundWrapper
            reportID={reportID}
            iouType={iouType}
            accessVariants={[CONST.IOU.ACCESS_VARIANTS.CREATE]}
            allPolicies={allPolicies}
        >

RESULT

2024-07-06.00-56-27.mp4

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Clicking back on "Page not found" page takes to a workspace page.

What is the root cause of that problem?

AccessOrNotFound page leads to workspace page if policy ID is passed.

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 98 in c5eafd3

    
           onBackButtonPress={() => Navigation.goBack(policyID ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined)}

What changes do you think we should make in order to solve the problem?

Add shouldOpenProfileOnBackPress as a prop in AccessOrNotFoundWrapper:

Update onBackButtonPress:

onBackButtonPress={() => Navigation.goBack(shouldOpenProfileOnBackPress && policyID ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined)}

We also need to discuss if we want to keep shouldOpenProfileOnBackPress as true by default or should we keep it as false. If we want to keep the existing flow in other places, we will need to make it's default value as true.

function AccessOrNotFoundWrapper({accessVariants = [], fullPageNotFoundViewProps, shouldBeBlocked, shouldOpenProfileOnBackPress = true, ...props}: AccessOrNotFoundWrapperProps)

shouldOpenProfileOnBackPress will be passed to PageNotFoundFallback.

Now, in IOURequestStartPage, pass it as false:

<AccessOrNotFoundWrapper
    reportID={reportID}
    iouType={iouType}
    policyID={policy?.id}
    accessVariants={[CONST.IOU.ACCESS_VARIANTS.CREATE]}
    allPolicies={allPolicies}
    shouldOpenProfileOnBackPress={false}
>

We might need to pass shouldOpenProfileOnBackPress from multiple places depending on what we are keeping as the default value.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking back "on page not found" page takes you to a workspace page

What is the root cause of that problem?

We have two bugs here

When the expense is paid, the submit expense options doesn't disappear immediately. The RCA is we compare the menuItems prop wrong here so when it's changed, the component doesn't re-render.

App/src/components/PopoverMenu.tsx

Line 266 in b0947e0

!lodashIsEqual(prevProps.menuItems, nextProps.menuItems) &&

Clicking back "on page not found" page takes you to a workspace page
. The RCA is in AccessOrNotFoundWrapper, we always go back to policy page when we click on back button if the policyID exists.

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 98 in b0947e0

    
           onBackButtonPress={() => Navigation.goBack(policyID ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined)}

What changes do you think we should make in order to solve the problem?

When the expense is paid, the submit expense options doesn't disappear immediately

For the first bug we should update the compare for menuItems correctly

lodashIsEqual(prevProps.menuItems, nextProps.menuItems) &&

App/src/components/PopoverMenu.tsx

Line 266 in b0947e0

!lodashIsEqual(prevProps.menuItems, nextProps.menuItems) &&

Clicking back "on page not found" page takes you to a workspace page

This component is used in both IOURequestStartPage and policy pages.

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 98 in b0947e0

    
           onBackButtonPress={() => Navigation.goBack(policyID ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined)}

We can add an extra prop in PageNotFoundFallback like isMoneyRequest

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 87 in b0947e0

    
           function PageNotFoundFallback({policyID, shouldShowFullScreenFallback, fullPageNotFoundViewProps}: PageNotFoundFallbackProps) {

And update the condition here to not go back to policy profile page if we're in money request flow

() => Navigation.goBack(policyID && !isMoneyRequest ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined)

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 98 in b0947e0

    
           onBackButtonPress={() => Navigation.goBack(policyID ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined)}

And then pass isMoneyRequest={isMoneyRequest} to PageNotFoundFallback here

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 140 in b0947e0

<PageNotFoundFallback

What alternative solutions did you explore? (Optional)

@miljakljajic

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

Job added to Upwork: https://www.upwork.com/jobs/~019f96054ddd649966

@thesahindia

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@thesahindia

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

page not found when click new submit expense #45567

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

@thesahindia requires payment through NewDot Manual Requests
@nkdengineer requires payment automatic offer (Contributor)

@thesahindia

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@thesahindia

@thesahindia is owed 250 for their work reviewing this issue

@thesahindia

@thesahindia do we need a regression test for this issue?

@nkdengineer paid in upwork

We should add a test case, here are the steps -

For actions menu -

Login with account A and B on different devices or browsers
As user A request money from User B > Go to that IOU report
Click on "+" to open the actions menu
Now use account B and pay the expense
On account A screen wait for a few seconds
Verify that the "submit expense" option disappear

For clicking back "on page not found" page takes you to a workspace page -

Login with account A and B on different devices or browsers
As user A request money from User B > Go to that IOU report
Click on "+" to open the actions menu
Now use account B and pay the expense
On account A quickly click on "submit expense"
Wait for a few seconds, you will see the not found page
Click at the back button
Verify it takes you back to report screen

Thank you!

@miljakljajic

~~@miljakljajic, looks like we don't have a payment summary here. Could you please add one? I need it for getting the payment approved.~~

Missed the comment! We already have it here.

@thesahindia

$250 approved for @thesahindia based on this payment summary

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-07] [$250] IOU - Clicking back "on page not found" page takes you to a workspace page #44924

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

18 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<AccessOrNotFoundWrapper
	reportID={reportID}
	iouType={iouType}
	policyID={policy?.id}
	accessVariants={[CONST.IOU.ACCESS_VARIANTS.CREATE]}
	allPolicies={allPolicies}
	>

[HOLD for payment 2024-08-07] [$250] IOU - Clicking back "on page not found" page takes you to a workspace page #44924

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 5, 2024

nyomanjyotisa commented on Jul 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ShridharGoel commented on Jul 6, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

nkdengineer commented on Jul 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 8, 2024

melvin-bot commented on Jul 10, 2024

melvin-bot commented on Jul 10, 2024

18 remaining items

melvin-bot commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

miljakljajic commented on Aug 7, 2024

miljakljajic commented on Aug 7, 2024

thesahindia commented on Aug 8, 2024

miljakljajic commented on Aug 8, 2024

thesahindia commented on Sep 10, 2024

garrettmknight commented on Sep 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions