Skip to content

[HOLD for payment 2024-08-01] [$250] Expense report - System message "randomly selected for review" displayed with markdown #45141

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4703834
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team

Action Performed:

Rrecondition: user A is set as admin-approver and user B is a member of a workspace, as a workspace admin set Randomly route reports for manual approval in OD to 50%. Also in Reports tab "How often expenses submit :' choose "Weekly"

  1. [user B] On secondary device submit 2 expense reports with the same expenses to trigger manual review system message
  2. [user A] Open the app and log in
  3. [user A] Navigate to the workspace chat
  4. [user A] Open the first submitted report with the same expense

Expected Result:

The system message "This report was randomly selected for manual review" is displayed without markdown

Actual Result:

The system message is displayed with the markdown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6536597_1720506318486.IMG_8051.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01642f4710fbdb092e
  • Upwork Job ID: 1811525296681690453
  • Last Price Increase: 2024-07-18
Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 10, 2024
  2. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jul 10, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jul 10, 2024

    @izarutskaya
    Author

    @stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Jul 10, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. izarutskaya commented on Jul 10, 2024

    @izarutskaya
    Author

    Production

    Recording.586.mp4
  8. 57 remaining items

  9. JmillsExpensify commented on Aug 2, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @Pujan92

  10. JmillsExpensify commented on Aug 3, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

  11. melvin-bot commented on Aug 5, 2024

    @melvin-bot

    @nkuoch, @Pujan92, @stephanieelliott, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. stephanieelliott commented on Aug 6, 2024

    @stephanieelliott
    Contributor

    Hey @Pujan92 this is just waiting for you to complete the BZ checklist!

  13. stephanieelliott commented on Aug 8, 2024

    @stephanieelliott
    Contributor

    Bump here @Pujan92, can you please complete the BZ checklist?

  14. Pujan92 commented on Aug 8, 2024

    @Pujan92
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. [user A] Invite user B to the workspace
    2. [user B] Submit two expenses in that workspace with the similar details to trigger a manual review system message
    3. [user A] Navigate to the workspace chat
    4. [user A] Open the submitted report
    5. [user A] Verify the "randomly selected for review" message isn't rendered in markdown form
  15. melvin-bot commented on Aug 13, 2024

    @melvin-bot

    @nkuoch, @Pujan92, @stephanieelliott, @bernhardoj Huh... This is 4 days overdue. Who can take care of this?

  16. stephanieelliott commented on Aug 13, 2024

    @stephanieelliott
    Contributor

    Issue created for new test case: https://github.com/Expensify/Expensify/issues/420217

    All done here, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions