You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-01] [$250] Expense report - System message "randomly selected for review" displayed with markdown #45141
Rrecondition: user A is set as admin-approver and user B is a member of a workspace, as a workspace admin set Randomly route reports for manual approval in OD to 50%. Also in Reports tab "How often expenses submit :' choose "Weekly"
[user B] On secondary device submit 2 expense reports with the same expenses to trigger manual review system message
[user A] Open the app and log in
[user A] Navigate to the workspace chat
[user A] Open the first submitted report with the same expense
Expected Result:
The system message "This report was randomly selected for manual review" is displayed without markdown
Actual Result:
The system message is displayed with the markdown
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@Pujan92] Determine if we should create a regression test for this bug. - Yes
[@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
[user A] Invite user B to the workspace
[user B] Submit two expenses in that workspace with the similar details to trigger a manual review system message
[user A] Navigate to the workspace chat
[user A] Open the submitted report
[user A] Verify the "randomly selected for review" message isn't rendered in markdown form
Activity
melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to @nkuoch (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 10, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Jul 10, 2024
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Jul 10, 2024
We think this issue might be related to the #collect project.
izarutskaya commentedon Jul 10, 2024
Production
Recording.586.mp4
57 remaining items
JmillsExpensify commentedon Aug 2, 2024
$250 approved for @Pujan92
JmillsExpensify commentedon Aug 3, 2024
$250 approved for @bernhardoj
melvin-bot commentedon Aug 5, 2024
@nkuoch, @Pujan92, @stephanieelliott, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
stephanieelliott commentedon Aug 6, 2024
Hey @Pujan92 this is just waiting for you to complete the BZ checklist!
stephanieelliott commentedon Aug 8, 2024
Bump here @Pujan92, can you please complete the BZ checklist?
Pujan92 commentedon Aug 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Steps
melvin-bot commentedon Aug 13, 2024
@nkuoch, @Pujan92, @stephanieelliott, @bernhardoj Huh... This is 4 days overdue. Who can take care of this?
stephanieelliott commentedon Aug 13, 2024
Issue created for new test case: https://github.com/Expensify/Expensify/issues/420217
All done here, thanks!