Repository navigation
[HOLD for payment 2024-07-22] [$500] Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android #45152
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Launch New Expensify app
- Go to workspace chat
- Submit some expenses
- Click on the expense preview
- Go back and forth between main chat, expense report and expense thread
Expected Result:
App will not flicker when switching between expense reports
Actual Result:
App flickers when switching between expense reports
On Android, keyboard is dismissed when trying to focus on the composer
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6537869_1720617424375.Android.mp4
Bug6537869_1720617424384.RPReplay_Final1720609502.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~013ddb1dcdf7db2cf6
- Upwork Job ID: 1811353829124565469
- Last Price Increase: 2024-07-12
Issue Owner
Current Issue Owner: @garrettmknightMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to @danieldoglas (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 10, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jul 10, 2024
@danieldoglas FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's bug and can be handled by external contributors
lanitochka17 commentedon Jul 10, 2024
We think that this bug might be related to #vip-vsp
danieldoglas commentedon Jul 11, 2024
I don't think this is related to backend, removing the
DeployBlockertagizarutskaya commentedon Jul 11, 2024
@danieldoglas Also the app is flickering when a new user finishes the onboarding flow. It flickers again after tapping on the "Get started" button. The issue can't be reproduced with the same account after this.
Let me know please if we need to create a new issue. Thanks
Bug6538707_1720686908936.PTZT3012.mp4
[-]Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android[/-][+][$250] Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android[/+]melvin-bot commentedon Jul 11, 2024
Job added to Upwork: https://www.upwork.com/jobs/~013ddb1dcdf7db2cf6
39 remaining items
[-][$500] Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android[/-][+][HOLD for payment 2024-07-24] [$500] Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android[/+]melvin-bot commentedon Jul 17, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
allgandalf commentedon Jul 17, 2024
can someone please update the date for payment it should be [HOLD for payment 2024-07-22] instead :))
[-][HOLD for payment 2024-07-24] [$500] Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android[/-][+][HOLD for payment 2024-07-22] [$500] Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android[/+]garrettmknight commentedon Jul 17, 2024
Thanks @Julesssss !
allgandalf commentedon Jul 18, 2024
The PR that introduced the bug has been identified. Link to the PR: [CP Staging] Add freezeScreenWithLazyLoading function #44544
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44544/files#r1682508572
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
I don't really think a regression test is needed here, this happened in an normal flow, like opening the compose.
But do let me know if we need a test at all, would be happy to provide :))
allgandalf commentedon Jul 22, 2024
This is ready for payment today @garrettmknight , thanks :)
ikevin127 commentedon Jul 22, 2024
Payments summary: #45152 (comment).
melvin-bot commentedon Jul 22, 2024
Payment Summary
Upwork Job
BugZero Checklist (@garrettmknight)