You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-05] [$250] Task – Assignee appears in LHN only after go back online if change it offline #45167
Please re-state the problem that we are trying to solve in this issue.
Assignee appears in LHN only after go back online if change it offline
What is the root cause of that problem?
The format of html of task edited action doesn't match with the userMention regex /<mention-user accountID="(\d+)" *\/>/gi when we convert HTML to text so before the edit task API is complete, the assignee doesn't display in LHN
changed the title [-]Task – Assignee appears in LHN only after go back online if change it offline[/-][+][$250] Task – Assignee appears in LHN only after go back online if change it offline[/+]on Jul 12, 2024
Torn here. With the new assignee being greyed out, I wouldn't expect it to be accurate elsewhere. That said... there's no details in LHN, I would expect the old assignee to show. What do you think @shubham1206agra ?
Torn here. With the new assignee being greyed out, I wouldn't expect it to be accurate elsewhere. That said... there's no details in LHN, I would expect the old assignee to show. What do you think @shubham1206agra ?
@mallenexpensify We should show the new assignee instead here. Since optimistic action assumes the state the action would be successful. And in this case successful action would be changed assignee.
changed the title [-][$250] Task – Assignee appears in LHN only after go back online if change it offline[/-][+][HOLD for payment 2024-08-05] [$250] Task – Assignee appears in LHN only after go back online if change it offline[/+]on Jul 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@shubham1206agra] Determine if we should create a regression test for this bug.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
[@shubham1206agra] Determine if we should create a regression test for this bug. No since the bug was basic and will be caught again in future by basic task tests.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.izarutskaya commentedon Jul 10, 2024
We think this issue might be related to the #vip-vsb.
nkdengineer commentedon Jul 10, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Assignee appears in LHN only after go back online if change it offline
What is the root cause of that problem?
The format of
htmlof task edited action doesn't match with theuserMentionregex/<mention-user accountID="(\d+)" *\/>/giwhen we convert HTML to text so before the edit task API is complete, the assignee doesn't display in LHNApp/src/libs/ReportUtils.ts
Lines 4912 to 4915 in 7bed113
What changes do you think we should make in order to solve the problem?
Update the HTML here in the same format as the data that is returned from BE
App/src/libs/ReportUtils.ts
Lines 4912 to 4915 in 7bed113
What alternative solutions did you explore? (Optional)
[-]Task – Assignee appears in LHN only after go back online if change it offline[/-][+][$250] Task – Assignee appears in LHN only after go back online if change it offline[/+]melvin-bot commentedon Jul 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01e2d6ef7ce1dc54d0
melvin-bot commentedon Jul 12, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)mallenexpensify commentedon Jul 12, 2024
Torn here. With the new assignee being greyed out, I wouldn't expect it to be accurate elsewhere. That said... there's no details in LHN, I would expect the old assignee to show. What do you think @shubham1206agra ?
shubham1206agra commentedon Jul 12, 2024
@mallenexpensify We should show the new assignee instead here. Since optimistic action assumes the state the action would be successful. And in this case successful action would be changed assignee.
22 remaining items
[-][$250] Task – Assignee appears in LHN only after go back online if change it offline[/-][+][HOLD for payment 2024-08-05] [$250] Task – Assignee appears in LHN only after go back online if change it offline[/+]melvin-bot commentedon Jul 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mallenexpensify commentedon Aug 7, 2024
Contributor: @nkdengineer paid $250 via Upwork
Contributor+: @shubham1206agra paid $250 via Upwork
@shubham1206agra , plz complete the BZ checklist above.
shubham1206agra commentedon Aug 7, 2024
@mallenexpensify I also require payment through Upwork.
shubham1206agra commentedon Aug 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mallenexpensify commentedon Aug 7, 2024
Thanks @shubham1206agra , got ya paid, updated confirmation post ablve.
@shubham1206agra any reason we wouldn't want a test case for this?
shubham1206agra commentedon Aug 8, 2024
This was a basic bug which should be caught again in QA (if it happens) whenever user changes the assignee.