Skip to content

[PAID] Workspace - Endless skeleton loader after login if the account is added to a workspace #45212

New issue
New issue
Closed
Closed
[PAID] Workspace - Endless skeleton loader after login if the account is added to a workspace#45212
Assignees
francoislstrepanier03rayane-d
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Jul 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/Web-Expensify/pull/42621 https://github.com/Expensify/Web-Expensify/pull/42602

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. User A: Log in with a new Gmail account
  3. User A: Create a workspace
  4. User A: Navigate to Workspace settings - Members
  5. User A: Invite a Gmail address that doesn't have an account yet (User B)
  6. User B: Open Chrome in incognito mode
  7. User B: Navigate to https://staging.new.expensify.com/
  8. User B: Log in

Expected Result:

The workspace chat should load with minimal loading animation

Actual Result:

Endless skeleton loader after login if the account is added to a workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538239_1720636518054.bandicam_2024-07-10_20-27-19-679.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 10, 2024
  2. melvin-bot
    assigned
    francoisl
    on Jul 10, 2024

  3. melvin-bot commented on Jul 10, 2024

    @melvin-bot
    melvin-botBot
    on Jul 10, 2024 – with Melvin Bot

    Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    on Jul 10, 2024

  5. github-actions commented on Jul 10, 2024

    @github-actions
    github-actionsBot
    on Jul 10, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  6. lanitochka17 commented on Jul 10, 2024

    @lanitochka17
    lanitochka17
    on Jul 10, 2024
    Author

    @francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  7. lanitochka17
    closed this as completedon Jul 10, 2024
  8. lanitochka17
    reopened this on Jul 10, 2024

  9. francoisl commented on Jul 10, 2024

    @francoisl
    francoisl
    on Jul 10, 2024
    Contributor

    I can repro too.

    One difference between prod and staging is that on production there's a call to OpenReport at some point after signing in, which I don't see on staging. I don't know if that's the reason, but could be a lead.

    Production Staging
    image image
  10. francoisl
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 10, 2024

  11. melvin-bot commented on Jul 10, 2024

    @melvin-bot
    melvin-botBot
    on Jul 10, 2024 – with Melvin Bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  12. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 10, 2024

  13. 20 remaining items

  14. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jul 17, 2024
  15. melvin-bot
    changed the title [-]Workspace - Endless skeleton loader after login if the account is added to a workspace[/-] [+][HOLD for payment 2024-07-24] Workspace - Endless skeleton loader after login if the account is added to a workspace[/+] on Jul 17, 2024
  16. melvin-bot
    removed
    ReviewingHas a PR in review
    on Jul 17, 2024

  17. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botBot
    on Jul 17, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botBot
    on Jul 17, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

    For reference, here are some details about the assignees on this issue:

  19. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botBot
    on Jul 17, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
    • [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rayane-djouah] Determine if we should create a regression test for this bug.
    • [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  20. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jul 23, 2024

  21. rayane-d commented on Jul 23, 2024

    @rayane-d
    rayane-d
    on Jul 23, 2024
    Contributor

  22. strepanier03 commented on Jul 24, 2024

    @strepanier03
    strepanier03
    on Jul 24, 2024
    Contributor

    @rayane-djouah - Thanks for the checklist!

    I sent you an offer on Upwork and will keep an eye for the acceptance email to come through.

  23. rayane-d commented on Jul 24, 2024

    @rayane-d
    rayane-d
    on Jul 24, 2024
    Contributor

    @strepanier03 - Accepted, Thanks!

  24. strepanier03 commented on Jul 24, 2024

    @strepanier03
    strepanier03
    on Jul 24, 2024
    Contributor

    Paid out the contract and closed it. Thanks @rayane-djouah for accepting it so quickly.

  25. strepanier03
    changed the title [-][HOLD for payment 2024-07-24] Workspace - Endless skeleton loader after login if the account is added to a workspace[/-] [+][PAID] Workspace - Endless skeleton loader after login if the account is added to a workspace[/+] on Jul 24, 2024
  26. strepanier03
    closed this as completedon Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions