[HOLD for payment 2024-07-24] Investigate workflow job failing on main: test / test (job 3)

@bernhardoj

🚨 Failure Summary 🚨:

📋 Job Name: test / test (job 3)
🔧 Failure in Workflow: Process new code merged to main
🔗 Triggered by PR: PR Link
👤 PR Author: @bernhardoj
🤝 Merged by: @dangrous
🐛 Error Message:
warning: The following actions uses Node.js version which is deprecated and will be forced to run on node20: SimenB/github-actions-cpu-cores@31e91de. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
failure: Process completed with exit code 1.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named test / test (job 3).
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

Why the PR caused the job to fail?
Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

@JKobrynski

@JKobrynski do you mind taking a look at this one? Looks like it's the new tests you added in ~~#44838~~ #44072 - I'm wondering if the Onyx.multiSet() calls are overlapping and causing the tests to be flakey.

sorry not that PR - this one! #44072

I think it's because the last test group doesn't have an afterEach? Maybe should add:

afterEach(async () => {
    await Onyx.clear();
    await Onyx.multiSet({
 
 
 
 [ONYXKEYS.NVP_PRIVATE_OWNER_BILLING_GRACE_PERIOD_END]: null,
    [ONYXKEYS.NVP_PRIVATE_AMOUNT_OWED]: null,
    [ONYXKEYS.NVP_PRIVATE_BILLING_DISPUTE_PENDING]: null,
    [ONYXKEYS.NVP_PRIVATE_STRIPE_CUSTOMER_ID]: null,
    [ONYXKEYS.NVP_PRIVATE_BILLING_STATUS]: null,
    [ONYXKEYS.FUND_LIST]: null,
 
 
 
 [ONYXKEYS.SUBSCRIPTION_RETRY_BILLING_STATUS_SUCCESSFUL]: null,
    [ONYXKEYS.SUBSCRIPTION_RETRY_BILLING_STATUS_FAILED]: null,
    });
});

(but correct spacing)

Fix PR up!

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix Flakey SubscriptionUtils Test #45351

If no regressions arise, payment will be issued on 2024-07-24. 🎊

Closing this out, no payment required.

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-24] Investigate workflow job failing on main: test / test (job 3) #45340

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-24] Investigate workflow job failing on main: test / test (job 3) #45340

Description

Activity

dangrous commented on Jul 12, 2024

dangrous commented on Jul 12, 2024

dangrous commented on Jul 12, 2024

dangrous commented on Jul 12, 2024

melvin-bot commented on Jul 17, 2024

melvin-bot commented on Jul 17, 2024

dangrous commented on Jul 24, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions