[HOLD for Payment 2024-08-26] Accessing one expense reports from search opening transaction view instead of report view

@shawnborton

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.06-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721024057246389

Action Performed:

As a submitter submit a report with one expense to the workspace
Go to search and click on the expense created in step 1

Expected Result:

clicking on any expense in the Search page where the expense is the only expense on a report opens up the report view instead of the transaction view

Here is thinking on why we should show the report view when viewing a single expense on a one-expense report:
we get a much more consistent experience with workspace chat rooms - in the attached video, see the difference when you view an expense from the workspace chat vs when you view it from Search
we limit user exposure to our multiple levels of navigation hierarchy when it comes to the Workspace chat > Report > Expense relationship. This way if someone views the expense from Search and leaves a comment, we are only showing the report thread in their Inbox LHN
we expose the actual action button a user might want to take on the expense. For example, it's weird if the Search page is going to eventually show a "Submit" button on the expense row, yet you wouldn't be able to see that same button on the expense once you open it - you'd have to navigate one level up to the report (which most users will have no idea why that's even a thing) to see those report action buttons
still think it makes sense to show the transaction view when you are trying to view an individual transaction from a grouped batch. But I do think the above change would make a much better experience for the majority of cases where it's a one-expense report.

Actual Result:

Expenses on one-expense reports accessed from the Search > Expenses page open up the transaction view instead of the report view

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Recording.326.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @muttmuure

@muttmuure

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Transaction report opens instead of expense report.

What is the root cause of that problem?

When accessing any transaction, in here, we don't have logic to check if it is only transaction in report.

What changes do you think we should make in order to solve the problem?

We need to update it to:

        if (SearchUtils.isTransactionListItemType(item)) {
            const transactionReport = getAllReports?.()?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
            const parentReportAction = ReportActionsUtils.getReportAction(transactionReport?.parentReportID ?? '-1', transactionReport?.parentReportActionID ?? '-1');
            if (ReportUtils.isOneTransactionThread(reportID, transactionReport?.parentReportID, parentReportAction) && transactionReport?.parentReportID) {
                reportID = transactionReport?.parentReportID;
            }
        }

In above, we check if the accessed transaction is the one transaction thread or not. If true, access its expense report instead of transaction report.
A similar logic should be updated to it:

        let oneTransactionReportID;
        const transactionThreadReportID = transactionItem.transactionThreadReportID;
        const transactionReport = getAllReports?.()?.[`${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`];
        const parentReportAction = ReportActionsUtils.getReportAction(transactionReport?.parentReportID ?? '-1', transactionReport?.parentReportActionID ?? '-1');
        if (ReportUtils.isOneTransactionThread(transactionThreadReportID, transactionReport?.parentReportID, parentReportAction) && transactionReport?.parentReportID) {
            oneTransactionReportID = transactionReport?.parentReportID;
        }
        Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute(currentQuery, oneTransactionReportID ?? transactionItem.transactionThreadReportID));

Alternative solution

We can check if the transaction is one transaction thread on BE side, so the transaction data return in Search API will contain an additional props, named isOneTransactionThreadReport.
We need to update it to:

        if (item.isOneTransactionThreadReport) {
                reportID = item.reportID;
        }

A similar logic should be updated to it:

        let oneTransactionReportID;
        if (transactionItem.isOneTransactionThreadReport) {
            oneTransactionReportID = transactionReport?.reportID;
        }
        Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute(currentQuery, oneTransactionReportID ?? transactionItem.transactionThreadReportID));

Proposal updated

@tienifr

@tienifr I'm not sure that your solution will work because we might not have the report or reportActions available in Onyx given that the Search API only returns data in the snapshot_ key. I think we'll need to work on a solution on the backend.

@luacmartins

@luacmartins I tested the app with my solution and it works well. Can you help me reproduce the case "we might not have the report or reportActions available in Onyx"? Thanks

Updated alternative solution in case we want to fix from BE side as well.

@tienifr

@tienifr I just tried this in my account:

Go to search page
Sort transactions by ascending date
Get the transactionID from an old transaction (in my case it was from 2021)
Verified that the transaction, report, reportActions key for that transaction didn't exist in Onyx

@tienifr

@tienifr thanks for the updated proposal. Can't we just use the reportID if isOneTransactionThreadReport = true?

@luacmartins

@luacmartins

Can't we just use the reportID if isOneTransactionThreadReport = true

Yeah, it makes sense. I tested and it works well, we can use transaction.reportID instead of introducing a new parentReportID props. I updated alternative proposal.

@muttmuure

@muttmuure - Offer accepted

@muttmuure

@muttmuure Friendly bump

Paid

Reopening this issue since it seems like the problem is back

PR in review

^ false positive

This is fixed on staging, we can close this one

Navigation Menu

Repository navigation

[HOLD for Payment 2024-08-26] Accessing one expense reports from `search` opening transaction view instead of report view #45408

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Alternative solution

Proposal updated

37 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for Payment 2024-08-26] Accessing one expense reports from search opening transaction view instead of report view #45408

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 15, 2024

tienifr commented on Jul 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Alternative solution

tienifr commented on Jul 15, 2024

Proposal updated

luacmartins commented on Jul 15, 2024

tienifr commented on Jul 15, 2024

tienifr commented on Jul 15, 2024

luacmartins commented on Jul 15, 2024

luacmartins commented on Jul 15, 2024

tienifr commented on Jul 15, 2024

37 remaining items

rayane-d commented on Aug 28, 2024

rayane-d commented on Aug 30, 2024

muttmuure commented on Aug 30, 2024

luacmartins commented on Sep 16, 2024

luacmartins commented on Sep 16, 2024

melvin-bot commented on Sep 20, 2024

rayane-d commented on Sep 20, 2024

rayane-d commented on Sep 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[HOLD for Payment 2024-08-26] Accessing one expense reports from `search` opening transaction view instead of report view #45408