Skip to content

[HOLD for payment 2024-08-29] [$250] Scan - Settings button does not open location permission settings #45431

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.7-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Click + > Submit expense > Scan
  4. Upload a receipt
  5. Submit the expense
  6. Click Settings

Expected Result:

Browser location permission access should appear

Actual Result:

The modal closes and the expense is submitted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2130.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01efe1095b2043e581
  • Upwork Job ID: 1812971045434010011
  • Last Price Increase: 2024-07-22
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 15, 2024
  2. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 15, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 15, 2024
  5. changed the title [-]Scan - Settings button does not open location permission settings[/-] [+][$250] Scan - Settings button does not open location permission settings[/+] on Jul 15, 2024
  6. melvin-bot commented on Jul 15, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 15, 2024
  8. 81 remaining items

  9. trjExpensify commented on Sep 2, 2024

    @trjExpensify
    Contributor

    Is there a regression test from the OG implementation you worked on for this modal, and if so, does it outline the expected behaviour for web and mobile?

  10. garrettmknight commented on Sep 4, 2024

    @garrettmknight
    Contributor

    $250 approved for @tienifr

  11. melvin-bot commented on Sep 6, 2024

    @melvin-bot

    @Julesssss, @trjExpensify, @allroundexperts, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. trjExpensify commented on Sep 6, 2024

    @trjExpensify
    Contributor

    Is there a regression test from the OG implementation you worked on for this modal, and if so, does it outline the expected behaviour for web and mobile?

    Bump on this Q.

  13. Julesssss commented on Sep 9, 2024

    @Julesssss
    Contributor

    Is there a regression test from the OG implementation you worked on for this modal, and if so, does it outline the expected behaviour for web and mobile?

    We need to update the existing test case to handle the unique expected results for web/mWeb. I created a QA test update request here to do so. I think we can close out this issue after payment.

  14. trjExpensify commented on Sep 9, 2024

    @trjExpensify
    Contributor

    Great, thank you for that.

    I think we can close out this issue after payment.

    Yep, this can now proceed to payment. Payment summary as follows:

    Both are free to request on ND now. Closing!

  15. JmillsExpensify commented on Oct 8, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions