Skip to content

[HOLD for payment 2024-08-09] [$250] Expense - Report turns to skeleton after deleting expense with comments offline #45461

New issue
New issue
Closed
Closed
[HOLD for payment 2024-08-09] [$250] Expense - Report turns to skeleton after deleting expense with comments offline#45461
Assignees
parasharrajatthienlnamChristinadobrzynnkdengineer
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@izarutskaya
izarutskaya
opened on Jul 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to DM with any user that has no unsettled expense.
  3. Submit an expense.
  4. Click on the expense preview.
  5. Send a few comments.
  6. Go offline.
  7. Click on the report header.
  8. Click Delete expense.
  9. Delete the expense.

Expected Result:

Report will not turn to skeleton after deleting the expense offline.

Actual Result:

The part above the comments turns to skeleton after deleting the expense offline.
This issue only happens when there is only one expense.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6543519_1721109876583.20240716_140113.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d020bfa76c4b7e26
  • Upwork Job ID: 1813325690168936392
  • Last Price Increase: 2024-07-16
  • Automatic offers:
    • nkdengineer | Contributor | 103162922
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 16, 2024

  2. melvin-bot commented on Jul 16, 2024

    @melvin-bot
    melvin-botBot
    on Jul 16, 2024 – with Melvin Bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot
    assigned
    grgia
    and
    Christinadobrzyn
    on Jul 16, 2024

  4. melvin-bot commented on Jul 16, 2024

    @melvin-bot
    melvin-botBot
    on Jul 16, 2024 – with Melvin Bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Jul 16, 2024

  6. github-actions commented on Jul 16, 2024

    @github-actions
    github-actionsBot
    on Jul 16, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  7. izarutskaya commented on Jul 16, 2024

    @izarutskaya
    izarutskaya
    on Jul 16, 2024
    Author

    We think this issue might be related to the #collect project.

  8. Christinadobrzyn
    added this to [#whatsnext] #wave-collecton Jul 16, 2024

  9. Christinadobrzyn commented on Jul 16, 2024

    @Christinadobrzyn
    Christinadobrzyn
    on Jul 16, 2024
    Contributor

    Asking if this is related to #44798

  10. 35 remaining items

  11. melvin-bot commented on Aug 2, 2024

    @melvin-bot
    melvin-botBot
    on Aug 2, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Aug 2, 2024

    @melvin-bot
    melvin-botBot
    on Aug 2, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-09. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Aug 2, 2024

    @melvin-bot
    melvin-botBot
    on Aug 2, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat] Determine if we should create a regression test for this bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/418512

  14. parasharrajat commented on Aug 2, 2024

    @parasharrajat
    parasharrajat
    on Aug 2, 2024
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. Go to DM with any user that has no unsettled expense.
    2. Submit an expense.
    3. Click on the expense preview.
    4. Send a few comments.
    5. Go offline.
    6. Click on the report header.
    7. Click Delete expense.
    8. Delete the expense.
    9. Verify that: Report will not turn to skeleton after deleting the expense offline.

    Do you agree 👍 or 👎 ?

  15. Christinadobrzyn commented on Aug 7, 2024

    @Christinadobrzyn
    Christinadobrzyn
    on Aug 7, 2024
    Contributor

    Preparing for payment.

    Regression test - https://github.com/Expensify/Expensify/issues/418512

    Payouts due:

  16. Christinadobrzyn
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Aug 7, 2024

  17. Christinadobrzyn commented on Aug 8, 2024

    @Christinadobrzyn
    Christinadobrzyn
    on Aug 8, 2024
    Contributor

    payment scheduled for tomorrow

  18. melvin-bot
    added
    DailyKSv2
    and removed
    DailyKSv2
    on Aug 8, 2024

  19. Christinadobrzyn commented on Aug 9, 2024

    @Christinadobrzyn
    Christinadobrzyn
    on Aug 9, 2024
    Contributor

    payday is here! Paid out based on this payment summary - #45461 (comment)

    @parasharrajat please make sure to request a payment through NewDot. Thank you! Closing

  20. Christinadobrzyn
    closed this as completedon Aug 9, 2024
  21. github-project-automation
    moved this from Polish to Done in [#whatsnext] #wave-collecton Aug 9, 2024

  22. parasharrajat commented on Aug 30, 2024

    @parasharrajat
    parasharrajat
    on Aug 30, 2024
    Member

    Payment requested as per #45461 (comment)

  23. JmillsExpensify commented on Sep 2, 2024

    @JmillsExpensify
    JmillsExpensify
    on Sep 2, 2024
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions